search

Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 67 forks source link

Distance To Assets.tbx needs unit tests written. #528

Open ACueva opened 7 years ago

ACueva commented 7 years ago

Distance to Assets.tbx currently has no unit tests written.

Minimum Requirements:

Confidence that after unit tests are run that the toolbox works as expected. Tests Will need to be written to both run against ArcMap and ArcGIS Pro.

Max Requirements:

Ask yourself, "Am I writing tests for the sake of writing tests?". If they provided little to no value, please don't write one.

Main Focus:

Focus tests on workflows customers would use. If additional instructions on workflows are needed please refer to the solutions pages: http://solutions.arcgis.com/defense/help/distance-to-assets/

Tests needed:

ACueva commented 7 years ago

FYI @lfunkhouser @mfunk

csmoore commented 7 years ago

Note: issue depends on / related to #522 (add toolbox to repo)

adgiles commented 7 years ago

This toolbox contains no custom python code, it purely utilises out of the box tools, are we in danger here that we are writing test scripts that check that core tools work correctly?

mfunk commented 7 years ago

@pHill5136 Got this started in https://github.com/Esri/solutions-geoprocessing-toolbox/tree/dev/utils/test/distance_to_assets_tests Will reassign items in here and Asana to you per our discussion this morning.

adgiles commented 6 years ago

@mfunk do we know what the status of these tests are, I see that they are in the dev branch here:

https://github.com/Esri/solutions-geoprocessing-toolbox/tree/dev/utils/test/distance_to_assets_tests

can we close this issue out?