search

Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 69 forks source link

Geonames.tbx needs unit tests written. #532

Closed ACueva closed 7 years ago

ACueva commented 7 years ago

Geonames Tools.tbx currently has no unit tests written.

Minimum Requirements:

Confidence that after unit tests are run that the toolbox works as expected. Tests will need to be written to both run against ArcMap and ArcGIS Pro.

Max Requirements:

Ask yourself, "Am I writing tests for the sake of writing tests?". If they provided little to no value, please don't write one.

Main Focus:

Focus tests on workflows customers would use. If additional instructions on workflows are needed please refer to the solutions pages: http://solutions.arcgis.com/defense/help/geonames-locator/

Tests needed:

ACueva commented 7 years ago

Note: issue depends on / related to #533 (add toolbox to repo)

csmoore commented 7 years ago

@ACueva - ready to verify at: https://github.com/Esri/solutions-geoprocessing-toolbox/tree/dev/utils/test/geonames_tests

ACueva commented 7 years ago

Verified Geonames is running. There are errors in the test suite not related to Geonames. Will speak with @mfunk and log issues as needed.