search

Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 67 forks source link

ArcMap HotSpotsByArea ignores output workspace parameter #560

Closed csmoore closed 7 years ago

csmoore commented 7 years ago

Incident Analysis HotSpotsByArea ignores the output workspace parameter in ArcMap

Expected Behavior

Output data to be created in workspace set in output workspace parameter

Current Behavior

Output data is created in default environment workspace

Steps to Reproduce (for bugs)

  1. In ArcMap, run Incident Analysis HotSpotsByArea
  2. Set the output workspace parameter
  3. Observe that the output is not created in this workspace

image

Context

Your Environment

kgonzago commented 7 years ago

Executed tool twice and results were written to user specified workspace. Issue could not be reproduced.

topowright-zz commented 7 years ago

@kgonzago while testing issue #508 I am able to reproduce this issue with the latest from dev. I am running ArcMap 10.3.1. What version are you using?

What I am experiencing is that it is honoring the settings in my ArcMap session and not in the tool input. Steps to reproduce:

  1. Set the environment settings for geoprocessing in the ArcMap
  2. Run the Hot Spot by Area tool 3 (Results will be honored if you choose this same output. If you choose a different location the tool will not write to that location.) This is the same thing that @csmoore captured above: Here is another screenshot image The screenshot shows that the model is just inheriting the settings from the arcmap session.
topowright-zz commented 7 years ago

Also, I am finding that the tool will only write out one result, which I am not sure if this is because of this. I have experienced this in ArcMap.

topowright-zz commented 7 years ago

I am seeing some crazy behavior with what it is writing. It will take me some time to capture it. This is a placeholder until I can get capture what is happening. This is what I have done to see the issue still present:

  1. Start with a new ArcMap Session.
  2. Open the HotSpot By Area Tool.
  3. Input parameters for the tool
  4. Create a new geodatabase
  5. Select the new geodatabase as the output workspace The outputs will not be what you set (the new geodatabase), but a relic from a previous run.
topowright-zz commented 7 years ago

I was able to fix the issue with multiple layers not adding to the map. That was done in pull request #602 . It was an issue with how long the names were possibly. I fixed it by just taking away the words "selectvalue" in the output name.

BobBooth commented 7 years ago

@topowright - the "only one output" issue is also noted here: https://github.com/ArcGIS/solutions-defense/issues/423 It is something that cropped up before and was supposed to have been fixed: https://github.com/Esri/solutions-geoprocessing-toolbox/issues/497

At the time, the problem was that it was iterating the areas correctly, but then writing all of the outputs to the same path string, overwriting each one in turn.

topowright-zz commented 7 years ago

@BobBooth I have addressed the naming issues in PR #602. I am going to verify this issue. now.

ACueva commented 7 years ago

Verified we are now able to save the output to location specified when running the GP tool. 2017-09-19_14-11-04

ACueva commented 7 years ago

Verified a second time with @topowright present to confirm results.