Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 69 forks source link

CreateGeonamesGazetteerLocator Model does not open in Pro 2.1 #629

Open csmoore opened 6 years ago

csmoore commented 6 years ago

Using Pro 2.1 Beta 1 (2.1.9865), the tool CreateGeonamesGazetteerLocator can not be opened/run

image

Steps to Reproduce (for bugs)

  1. On Pro 2.1 (tested on (2.1.9865) ) view "Geonames Tools_pro.tbx"
  2. Attempt to view tool properties or Edit Model: CreateGeonamesGazetteerLocator
  3. Error: "Reading tool has failed" (Screenshot above)

Context

Your Environment

Current Dev branch Pro 2.1 Beta 1 (2.1.9865) Windows 10

csmoore commented 6 years ago

@mfunk @lfunkhouser @nfeuerstein - this should be passed onto the Pro team

csmoore commented 6 years ago

This is still an issue in the latest build: 2.1.9984

csmoore commented 6 years ago

This is still an issue as of 2.1.10195 - but the ArcMap toolbox/tool does open in Pro so we may need to recreate the Pro tool for 2.1.

BobBooth commented 6 years ago

I am willing to bet that this is a Pro packaging fail. I am able to open the Create Geonames Gazetteer Locator tool that is in the ArcMap folder from the unzip of the solution. image

BobBooth commented 6 years ago

That tool runs and creates a locator from Pro 2.1

BobBooth commented 6 years ago

I cannot rename the tool in the Pro flavor of the TBX, get a "reading tool failed" message. When I Edit the ArcMap version of the tool, I can see the model. Doesn't seem to call a script, so that kind of blows my theory. I was able to copy the model from the ArcMap toolbox into the Pro 2.1 project toolbox and open and run it. Guess the tool in the Pro 2.1 toolbox was corrupted somehow. image

topowright-zz commented 6 years ago

@adgiles this is something that could use your attention if you can get to it.

adgiles commented 6 years ago

@topowright I can replicate exactly what @BobBooth has documented above.

The pro toolbox runs fine in 1.4 & 2.0 but fails to open in 2.1.

The arcmap toolbox opens and runs in all versions of Pro.

I did raise the question back in July why we have a pro and map version of the toolbox when they are calling the exact same underlying scripts and models and a desktop toolbox has no issues being used in Pro.

The answer I was given was that if an arcmap toolbox is edited in pro it is not then backwards compatible to arcmap. I maintain that if a user edits a supplied solution in a later version of software which stops it being used on earlier versions then it is their responsibility, they can always restore the original version from the zip or download again. You are given a warning when you do this:

untitled

Do we know if the pro team have had any other issues with 1.4 models beings used in 2.1?

topowright-zz commented 6 years ago

Based on @adgiles comments today we might want to rethink how we are deploying multiple toolboxes for one solution. Maybe just one toolbox per solution and the user has the responsibility of managing application usage and version usage.

topowright-zz commented 6 years ago

Just spoke with Shitij Mehta on the model builder team and she is going to look further into this. She thinks that it is a bug with ArcGIS Pro and they are going to figure out more.

topowright-zz commented 6 years ago

Here is the issue in __ -> logged with core about this issue:

ArcGISPro/ModelBuilder/issues/226

I am moving this to a future sprint based on what we found from the model builder team. When we know more about what to do next we will then finish this effort.

esride-maf commented 6 years ago

cannot open model (created in ArGIS Pro 2.0) with Pro 2.1 image Any idea?

BobBooth commented 6 years ago

So, one option might be a pure Python solution, bypass the Pro model version compatibility issue.

esride-jts commented 4 years ago

This issue is still relevant for us. Would you be so kind and tell us when this is going to be fixed?

csmoore commented 4 years ago

@esride-jts - were you able to try the suggested workaround (using the ArcMap version of the toolbox) from - https://solutions.arcgis.com/defense/help/geonames-locator/

For some odd reason Pro was able to open the ArcMap version but not the model that was created in an earlier version of Pro.