Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 67 forks source link

Address issue #657 #658

Closed adgiles closed 6 years ago

adgiles commented 6 years ago

The script was reusing a rotate feature class function that was generic so that it could be used against any feature class. As part of this it used the arcpy.AddJoin_management to map over the existing feature class attributes. This process seemed to cause an issue in Pro.

As we know that there is only one attrribute field to map over (Grid) I have change script to do this in the search cursor and removed the join.

BobBooth commented 6 years ago

@adgiles - I have tested this change and it works. I do not have permission to review, so @csmoore or @kgonzago - please have a look at the code.

BobBooth commented 6 years ago

@adgiles - I tested in ArcMap (10.6.0.8321) and I'm seeing some strange behavior with the labeling of rotated, non-square grids created with the Create GRG from Area tool. Not sure if these are result of recent change or not. image "A" series starts in the middle of first row, proceeds to edge, then "B" series continues from opposite edge of first row. @topowright - FYI