Esri / solutions-geoprocessing-toolbox

Models, scripts, and tools for use in ArcGIS Desktop and Server to support defense and intelligence workflows.
Apache License 2.0
133 stars 67 forks source link

Labels off for rotated, non-square grids created with the Create GRG from Area tool #660

Closed BobBooth closed 6 years ago

BobBooth commented 6 years ago

Testing Create GRG from Area in ArcMap (10.6.0.8321) and I'm seeing some strange behavior with the labeling of rotated, non-square grids created with the Create GRG from Area tool. "A" series starts in the middle of first row, proceeds to edge, then "B" series continues from opposite edge of first row. image

Steps to Reproduce (for bugs)

  1. Run Create GRG from Area tool
  2. Create an area that is large enough to create a bunch of rows and cols for your cell size, and arrange for it to be rotated relative to the data frame.
  3. Set the Cell Width less than the Cell Height (e.g. 55 and 100 meters)
  4. Specify an output.
  5. Run the tool.

The labeling will be off.

Your Environment

ArcMap (10.6.0.8321)

BobBooth commented 6 years ago

@topowright - new issue for this problem found while testing https://github.com/Esri/solutions-geoprocessing-toolbox/pull/658 @adgiles

adgiles commented 6 years ago

@bbooth hopefully addressed in PR https://github.com/Esri/solutions-geoprocessing-toolbox/pull/661

bbooth commented 6 years ago

Wrong bbooth :)

adgiles commented 6 years ago

Sorry @bbooth @bobbooth

BobBooth commented 6 years ago

@adgiles - I just grabbed the latest copy of Dev and I'm getting an error message related to the polar region check. Tested in CA. image

adgiles commented 6 years ago

@BobBooth sorry I removed a variable that I thought wasn’t being used try this PR: https://github.com/Esri/solutions-geoprocessing-toolbox/pull/662

BobBooth commented 6 years ago

@adgiles - getting a Python error that verticalCells is referenced before assignment line 413 in GRGFromArea image

adgiles commented 6 years ago

Not sure what’s happening here as there should be no polar check in this tool. It looks like files have got merged together some how. Latest PR should hopefully be alright

BobBooth commented 6 years ago

https://github.com/Esri/solutions-geoprocessing-toolbox/pull/662 seems to have fixed it.