Create GRG from Point tool failing in Pro 2.2 build 11661 - module 'arcpy' has no attribute 'LoadSettings'

[BobBooth]

Tasks to be done - May 16th 2018

• [x] Verify Automated test run on 2.1 and 2.2

---

I ran the Create GRG from Point tool in Pro 2.2 build 11661, using the version of the tool found at: [server]\Development\Commercial\Solutions\DefenseSolutions\GriddedReferenceGraphic\6 I had set the coordinate system of the Pro Map to North America Lambert Conformal Conic, zoomed in to NE Ohio, the re-ran using a map in Web Mercator to make sure it wasn't a CS issue. It failed in Web Mercator too.

Err message: Start Time: Friday, March 2, 2018 1:07:06 PM Running script CreateGRGFromPoint... App environment: ARCGIS_PRO Creating Fishnet Grid Sorting the grid for labeling Adding field for labeling the grid Numbering the grids Rotating the grid PYTHON ERRORS:Traceback info: File "C:\Pro_2_2_IterationTesting_GRG\GriddedReferenceGraphic\ArcGIS Desktop\toolboxes\scripts\GRGUtilities.py", line 785, in GRGFromPoint RotateFeatureClass(tempSort, outputFeatureClass, rotation, pointExtents[0] + " " + pointExtents[1])Error Info:module 'arcpy' has no attribute 'LoadSettings' ImageArcPy ERRORS:Start Time: Friday, March 2, 2018 1:07:06 PMAdding Grid to in_memory\tempSort...Succeeded at Friday, March 2, 2018 1:07:06 PM (Elapsed Time: 0.01 seconds) Completed script Create GRG from Point... ImageFailed to execute (CreateGRGFromPoint). Failed at Friday, March 2, 2018 1:07:07 PM (Elapsed Time: 0.45 seconds)

This appears to be offending line: https://github.com/Esri/solutions-geoprocessing-toolbox/blob/929dee047b21c73dd1f200971330472be38b37eb/clearing_operations/scripts/GRGUtilities.py#L269

[BobBooth]

@adgiles - This is odd.
@llsjr2 - you didn't see this in your testing of the Clearing Operations Solution - Toolbox out of sync.

[BobBooth]

Re-testing this

[BobBooth]

Using tool from: [servername]Development\Commercial\Solutions\DefenseSolutions\GriddedReferenceGraphic\13 I re-ran the Jenkins build and don't see a version dated today.

[BobBooth]

If I create a GRG without rotation, the tool runs fine (in Pro 2.2.0_beta.1 + build.12026 and the 4/9/2018 build of GRG (Jenkins build process didn't seem to produce a newer one): However, if I create output with a rotation value set, it fails:

still seeing "module 'arcpy' has no attribute 'LoadSettings'" message, though the err message is not exactly the same as it was.

[BobBooth]

It is failing at the "Rotating the grid" stage.

[BobBooth]

The GRGUtilities.py file does include code that calls arcpy.LoadSettings

However, that should be OK, according to the Pro Python doc: http://pro.arcgis.com/en/pro-app/arcpy/functions/loadsettings.htm

[BobBooth]

This issue is still a problem, on Pro 2.2. Possibly Python at Pro 2.2 is not supporting arcpy.LoadSettings? @topowright - could you reach out the the GP/Pro Python folks and inquire if there have been any (intentional) changes?

[BobBooth]

This tool is working correctly in ArcMap 10.5.0.6491

[BobBooth]

This tool also works fine at Pro 2.1.0

So Pro 2.2 has an issue. @topowright

[lfunkhouser]

Was this working during previous iteration testing of 2.2?

[topowright-zz]

This was found during our last testing of 2.2 if I remember correctly. Bob was able to get this to work in 2.1 and ArcMap. We need to show this to the Pro team and get an understanding of what has changed in ArcGIS Pro 2.2

[topowright-zz]

This has been logged in the following issue:

/ArcGISPro/geoprocessing/issues/1640

[topowright-zz]

Moving this back to the sprint backlog being that we cannot work on this without input from core.

[ACueva]

From internal GitHub:

just replace your
if env_file: arcpy.LoadSettings(env_file)
with
if env_file: arcpy.gp.LoadSettings(env_file)

This should work in all versions.

[csmoore]

Made the changes above in branch - https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/csm/%23667-grg-no-rotate-featureclass - but there are some other problems with this method - RotateFeatureClass - not sure that the Rotate angle has worked on this tool in a while (since December?) - so still looking at this

[csmoore]

This is now working in ArcMap/Pro in this branch: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/csm/%23667-grg-no-rotate-featureclass

The only remaining issue is I get a very odd problem in Pro when I run from the test driver - one feature is missing (which causes the test to fail since feature count != rows X cols):

[csmoore]

Addressed in PR: https://github.com/Esri/military-tools-geoprocessing-toolbox/pull/294

[BobBooth]

Adding test case to checklist test https://github.com/ArcGIS/solutions-defense-test-catalog/blob/master/Tests/Gridded-Reference-Graphic_ArcMap-ArcGIS-Pro.md

[BobBooth]

Created a new checklist test for the GRG toolset in Military Tools.pyt and included specific step to test issue 667 in it. https://github.com/ArcGIS/solutions-defense-test-catalog/pull/134

[BobBooth]

Removing Verify Automated tag because this (rotation, in Pro) is tested in the automated test now.

[topowright-zz]

Tested this manually on build ArcGIS Pro 2.2 - 12584 using a grid angle of 36 with no problem.

Tested this manually on ArcMap 10.6 with no problems at all. Ran the unit test on 2.7 ArcMap 10.6 with no fails.

I need to run this test on 2.2 and 2.1 to make sure it passes now.

[kgonzago]

removing development tag since it's a verification issue via jenkins.

[ACueva]

Verified Checklist ~, asked @BobBooth for some minor revisions. Will re-verify once completed.~

[ACueva]

Verified in ArcMap (10.3.1 and 10.6.1) and ArcGIS Pro (2.1, and 2.2) GRG unit tests are not throwing any errors. http://dev0002292:8080/job/GP%20Unit%20tests/job/ArcGIS%20Pro%20Test%20Runner/101/console http://dev0002292:8080/job/GP%20Unit%20tests/job/ArcMap%20Test%20Runner%20Daily/89/console

[lfunkhouser]

Impeded until it can be tested from the production build location.

[BobBooth]

Tested on: Pro 2.2 - 12808 Pro 2.1.0 with the 6/7 build of Military tools from [location]\DefenseSolutions\MilitaryToolsForArcGIS\3.0\35 This issue (667) does not occur on either. Also tested the other two GRG tools on both and they work.