search

Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.
Apache License 2.0
3 stars 3 forks source link

Gridded Reference Graphic widget folder should be renamed #140

Closed dfoll closed 6 years ago

dfoll commented 6 years ago

Bug or Enhancement

In github, the folder that you use to drop in the WAB ...\client\stemapp\widgets folder is named "GRG", this is a different naming convention than the widgets that come with WAB, suggest changing the name of the folder to "GriddedReferenceGraphic"

I experimented with doing this myself, but it's more involved than simply changing the folder name.

Screenshots

image

dfoll commented 6 years ago

there is at least one specific area where documentation needs changed, we refer to the "GRG" folder, and this will need changed to refer to the "GriddedReferenceGraphic" folder http://solutions.arcgis.com/defense/help/gridded-reference-graphic/get-started/set-up-the-grg-solution-in-web-appbuilder.htm "Install the GRG widget" - step 5

Dbarnes1 commented 6 years ago

@joebayles I couldn't come up with a reason we left it this way, although I know we discussed it. @dfoll asked me and I thought it was intentional, but can't think of a reason why now.

dfoll commented 6 years ago

@adgiles I attempted to do this myself. because I changed a folder name, the changes show that I removed and replaced all the files, however the only actual changes I made I listed above. please review thoroughly.

This is in #143

This issue can not be closed until the documentation in cms has been updated.

adgiles commented 6 years ago

@dfoll All looks good, the thing that normally catches people out is not renaming the name property in the manifest.json. Tested the branch and it all works as expected. All merged and branch deleted.

ACueva commented 6 years ago

Verified these changes work in WAB-DE. 2018-01-12_8-45-09 2018-01-12_8-41-41

ACueva commented 6 years ago

Just an FYI, We aren't the only Widget that has their name cut off. Per @Jianxia this is something the WAB team is looking into for future releases.

dfoll commented 6 years ago

this change in folder name was documented in CMS in the location i stated above, removed G-Doc (CMS) label

joebayles commented 6 years ago

FYI - Naming it 'GRG' vice 'Gridded Reference Graphic' was precisely for this reason... It showed up as "Gridded Re..." in the menu.

topowright-zz commented 6 years ago

I will have to check if that is still the issue and we will have to move back to the previous name.