search

Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.
Apache License 2.0
3 stars 3 forks source link

Define number of rows and columns toggle options are reversed #144

Closed lfunkhouser closed 6 years ago

lfunkhouser commented 6 years ago

Issue reported by @MikeTschudi

Bug or Enhancement

The Define number of rows and columns toggle positions for "on" and "off" are reversed in the UI.

Repo Steps or Enhancement details

  1. Open GRG widget
  2. Select Define a Grid from an Area
  3. Select By Dimension
  4. Note the Define number of rows and columns toggle button.

The user slides the toggle right (red) to disable the option to input specified number of horizontal and vertical cells and slides it left (green) to enable the option to input a specified number of horizontal and vertical cells.

Screenshots

image

image

The standard for iOS-style toggles is slide right to get it on/enable/green and left to get it off/disable/red. image

Version found: GRG January 2018

topowright-zz commented 6 years ago

@lfunkhouser do you know if we heard back from core on this issue?

adgiles commented 6 years ago

Addressed in PR https://github.com/Esri/solutions-grg-widget/pull/155.

No documentation change required. Just needs to be verified and moved up to devtopia