Exposing the the showLabels function in the configuration

[joebayles]

Update

The Show Label button should be moved from the Grid Settings > Label Settings dialog to the Publish GRG dialog, just below the Publish button. It should still default to ON.

Original Issue

A key part of the Gridded Reference Graphic is the label. In the traditional app creation workflow, we require users to open the config.json of the app after it is created to add the showLabels : true function.

I think a much cleaner way (and less for the user to screw up) is to expose that function to the user in the widget configuration, like a simple switch.

After some research and consultation w/ @kgonzago, this would require a bit more than just adding it. It would require:

• Adding code to the widget
• For the label to show up, the user must refresh the browser
• If we were going to add an automatic refresh of the browser, that would require more work.

[Dbarnes1]

@lfunkhouser @nfeuerstein I think that this should be on our radar as a team to put into this sprint or the next. This would be a huge improvement in ease of use for the September release.

[adgiles]

@dbarnes1 I have already done the logic to make this work just need to wire it up to the UI

[Dbarnes1]

@adgiles sounds good, I'm placing it in our sprint backlog to track. @lfunkhouser let me know if we shouldn't do this.

[Dbarnes1]

@joebayles this labels toggle isn't in the latest version of your mockup/wireframe. Is that purposeful? Or are we still giving the users the ability to turn labels on and off for their grid? I'm assuming that we would still be able to turn the labels on and off once the grg is created by going to the Layer List widget and right clicking on grid layer

[joebayles]

@Dbarnes1 It never made it into the mockup past that crazy big diagram. Let's talk about this today.

[Dbarnes1]

After discussing with @joebayles I think that we don't need this button, with the assumption being that labels will be turned on when the GRG is created automatically. So the functionality is there, we just don't give users the option to choose whether they wan't GRG labeled or not. If users want to turn their grid labels off, they can go to the Layer List widget and turn labels off for the layer.

The toggle that we do want to implement is the option to show MGRS labels when you create a GRG based on that grid. That option can be tracked with this issue: https://github.com/ArcGIS/solutions-grg-widget/issues/3

[adgiles]

The assumption there is that the app that the widget is being used in has the layer list widget within it. I don't see any harm in providing this option at the widget level (probably the same for pop up as well)

[Dbarnes1]

In that case, @joebayles will add it to the mockup

[Dbarnes1]

@adgiles are we now able to show labels created as we the GRG's by default without manually editing the config json? It seems like that might be the case. If that is true, than I think we can close this issue.

In terms of providing an option for turning labels off, I don't think that this is necessary after discussing with the team

[joebayles]

Verified that it works in all of the panes, but should we bury it that far down? The other settings aren't going to get manipulated as often... I feel like we could bring it up a level, or even put it on the publishing dialog:

I don't want to remove it, it's totally useful instead of opening another widget just to switch on/off labels.

Any comments @ArcGIS/arcgis-defense-solutions? Otherwise, this is good to close.

[Dbarnes1]

I agree with @joebayles in that making it part of the publish GRG to portal page would help surface this setting and make it more visible

[adgiles]

Show labels toggle moved to the publish panel as per @joebayles mock up above.

Addressed in this commit: https://github.com/ArcGIS/solutions-grg-widget/commit/158f45ac2eec68d1f7e123eb574f7dd81abb7b44

[joebayles]

Verified.