Change name of "Label Format" parameter in tool Settings dialog

Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.

Apache License 2.0

3 stars 3 forks source link

Change name of "Label Format" parameter in tool Settings dialog #79

Closed elinz closed 7 years ago

elinz commented 7 years ago

Widget

The "Label Format" parameter in each tool Settings dialog should be change to "Label Style" to match the parameter name in the Configuration dialog.

Tool setting dialog:

Configuration dialog:

[ ] GRG from Area by Dimension
[ ] GRG from Area by Reference System
[ ] GRG from Point by Dimension
[ ] GRG from Point by Reference System

Version of widget

Bug or Enhancement

Repo Steps or Enhancement details

adgiles commented 7 years ago

I don't think this should be changed to label origin, but should be either style or format

elinz commented 7 years ago

@adgiles The screenshots in the issue were correct, my text wasn't. I was dealing with multiple changes in the widget settings vs. configuration page and typed in the wrong text. The label of the parameter should be changed to "Label Style".

adgiles commented 7 years ago

Addressed in this commit: https://github.com/ArcGIS/solutions-grg-widget/commit/4dace5088ee00c20a535266041bb2f3a77a9c063

untitled

llsjr2 commented 7 years ago

Verified changed to "Label Style". Settings topic updated to reflect change. Closing.

elinz commented 7 years ago

Verified fixed in tool GRG from Area by Dimension on 15 Sept 09:45. Verified fixed in tool GRG from Area by Reference System on 15 Sept 09:45. Verified fixed in tool GRG from Point by Dimension on 15 Sept 09:45. Verified fixed in tool GRG from Point by Reference System on 15 Sept 09:45. Closing issue.