Esri / solutions-grg-widget

A GRG (Gridded Reference Graphic) is a grid overlay used for a common reference point in many situations - from cordon and search operations to security for presidential inaugurations.
Apache License 2.0
3 stars 3 forks source link

Why have both "Clear GRG" and "Remove GRG Area" buttons? Condense into one button #89

Closed Dbarnes1 closed 7 years ago

Dbarnes1 commented 7 years ago

Widget

GRG

Bug or Enhancement

I'm wondering if it would be possible to combine the Clear GRG and Remove GRG Area buttons. I know that the Remove GRG Area button removes the preview area, whereas Clear GRG removes a non-published GRG after you click Create GRG. I don't think it would be confusing for this functionality to be combined in one button, so we have a general clear button that clears whatever you're working on in the GRG creation workflow.

An alternative that I think would be nice is for the Clear GRG button to be visually disabled until a GRG has been created, I'm thinking that it could be grayed out.

@adgiles thoughts? I'm putting this in the backlog because I think at present one of these features should be implemented.

elinz commented 7 years ago

I think it would be good to have a single "Clear GRG" button that would be used to remove the preview area and unpublished GRG if they exist.

adgiles commented 7 years ago

Addressed in commit: https://github.com/ArcGIS/solutions-grg-widget/commit/67604785eee4ef5bf1e2c300f2d43c8bf8260316

Dbarnes1 commented 7 years ago

this has been completed, we don't mention the clear button, or the old clear grg or remove grg area buttons in our documentation, so we're good to close