search

Esri / storymap-shortlist

The Shortlist story map application template by Esri
http://storymaps.arcgis.com/en/app-list/shortlist/
Apache License 2.0
43 stars 61 forks source link

Accessibility #36

Closed regan-sarwas closed 9 years ago

regan-sarwas commented 9 years ago

Added accessibility (primarily keyboard navigation) to Shortlist story map

glazou commented 9 years ago

Thanks for the pull request.

Before we merge it, I would like to know how we can make the focus outline to stand out less. The first reaction of all my colleagues without deficiency that have seen the red outline on tab were quite negative.

But I understand that having a focus outline with a high contrast is an important part of 508. Would you have another color to suggest that can satisfy everyone?

If we can't find a color that match 508 compliance, do you know if there is a solution to detect if the user would like that kind of accessibility features? (like detecting if they are using a screen reader?)

Or what about we enable some 508 features through a configuration flag and maybe a URL parameters?

regan-sarwas commented 9 years ago

I would have preferred to just let the browser provide its default highlight (light blue halo on safari and chrome, dotted black line on IE), but esri.css (part of the JavaScript API) turns off the focus for everything. I put in a feature request to get esri.css fixed, so that it only hides the focus on components in the JavaScript API. If that happens, then we should delete the css for styling the focus.

As it is, the style I've chosen is just meant to make it obvious. I think a designer should pick a color that works well with the color theme for the page.

Regan Sarwas, GIS Programmer National Park Service, Alaska Region, GIS Team 240 West 5th Avenue, Anchorage, AK 99501 regan_sarwas@nps.gov - 907-644-3548

On Oct 1, 2014, at 3:09 PM, glazou notifications@github.com wrote:

Thanks for the pull request.

Before we merge it, I would like to know how we can make the focus outline to stand out less. The first reaction of all my colleagues without deficiency that have seen the red outline on tab were quite negative.

But I understand that having a focus outline with a high contrast is an important part of 508. Would you have another color to suggest that can satisfy everyone?

If we can't find a color that match 508 compliance, do you know if there is a solution to detect if the user would like that kind of accessibility features? (like detecting if they are using a screen reader?)

Or what about we enable some 508 features through a configuration flag and maybe a URL parameters?

— Reply to this email directly or view it on GitHub.

glazou commented 9 years ago

The fix for the focus has made it to 3.11, much better

regan-sarwas commented 9 years ago

good news, thanks for letting me know.

On Mon, Oct 13, 2014 at 10:44 AM, glazou notifications@github.com wrote:

The fix for the focus has made it to 3.11, much better

— Reply to this email directly or view it on GitHub https://github.com/Esri/shortlist-storytelling-template-js/pull/36#issuecomment-58936408 .

Regan Sarwas, GIS Programmer National Park Service http://www.nps.gov, Alaska Region http://www.nps.gov/akso, GIS Team http://165.83.62.205/rgr/akgis/ 240 West 5th Avenue, Anchorage, AK 99501 https://maps.google.com/maps?safe=active&q=240+West+5th+Avenue,+Anchorage,+AK+99501&ie=UTF-8&hq=&hnear=0x56c89629a8f7513b:0x86a613e13a2a3761,240+W+5th+Ave,+Anchorage,+AK+99501&gl=us&ei=m9d1UIvfGezriQK3mYDwBQ&ved=0CCEQ8gEwAA regan_sarwas@nps.gov - 907-644-3548

glazou commented 9 years ago

Thanks, your PR has been incorporated in V1.4. Please let us know if we missed something.