search

Esri / street-data-processing-tools

ArcGIS geoprocessing toolbox containing tools to create and build a network dataset from commercial street data.
Apache License 2.0
36 stars 16 forks source link

Bugfixing CreateSignposts #44

Closed emiliardo78 closed 2 years ago

emiliardo78 commented 2 years ago

Fix error on CreateSignposts function while trying to read value from the Signs_geom fc for BR_RTEID and TOW_RTEID if their values are null

mmorang commented 2 years ago

Hello @emiliardo78, and thank you for your contribution.

We looked at your PR, and while the code changes themselves look fine, we do not want to merge this into the official tool because the tool is intended to work with the formatting of the source NAVSTREETS data, which comes from HERE in dBASE format and doesn’t contain any null values. Our guess that you're using data that has been modified in some way.

I'm going to close this PR, but if you would like to give us more details on your input data or your motivation for this change, we would be happy to revisit it.