search

Esri / terraformer-wkt-parser

Well-Known Text parser for Terraformer
MIT License
77 stars 30 forks source link

Typescript definition fixes #29

Closed darcyparker closed 7 years ago

darcyparker commented 7 years ago

I was having some problems with merging the .d.ts for WKT and terraformer's latest .d.ts. After fixing some issues here: https://github.com/Esri/Terraformer/pull/298 and seeing them merged, I made some similar updates here for WKT.

Run npm run test:ts, which now runs tslint, builds test.ts and runs the built test.js to verify.

jgravois commented 7 years ago

any reason you closed #28 and opened this PR against the same branch?

darcyparker commented 7 years ago

Sorry about closing #28. It was a bad idea in retrospect. I rebased... and resubmitted.

darcyparker commented 7 years ago

Similar to https://github.com/Esri/Terraformer/pull/299, I did not use 'node' as version in .travis.yml.

jgravois commented 7 years ago

no need to apologize for the closed PR 😄

i just wanted to make sure that you know we don't expect perfection initially and that we commonly commit and discuss (and rebase/squash afterward if we're feeling industrious) all in the original location.

jgravois commented 7 years ago

very cool. thanks again!