search

Esri / visibility-addin-dotnet

ArcGIS Add-in provides the capability to quickly do line of sight analyses.
Apache License 2.0
14 stars 19 forks source link

ENH-000105296 Add ability for Radial Line of Sight to use processing extent from observer points extent #194

Open nfeuerstein opened 7 years ago

nfeuerstein commented 7 years ago

Current State: (Added 3-1-2019) The visibility add-in can run LLOS on a elevation service with an acceptable time for the final return. The expectation is that RLOS will run using the same process that LLOS does. Based on the fact that both calls are to the gp tools it should expect that the process is similar

.

Salesforce ID: ENH-000105296
Salesforce Submitter: Andrew Johnson
Salesforce Submit Date: 5/19/2017 1:19 AM
Salesforce Bug Type: Product
Salesforce Severity: Low
Repro Data: (n/a)
Work Around: 1. Provide the appropriate/comparable step by step workflow to help illustrate the request.

1) Open RLOS from Military Tools
2) Add raster with large extent
3) Add a few observer points
4) Run the tool

2. What is the problem feature X is trying to solve? (i.e. What is the problem/limitation/design choice that is preventing the customer from moving forward?)

We have a 10 m cell size raster and it is 200x300 km in size. Using RLOS tool, we create two observer points in a certain 10x10 km area of interest on the raster. These points are set to 1000 m distances. If we do not set the geoprocessing extent of the previously mentioned 10x10 km area, RLOS takes overnight to calculate results and it crashes with the previously mentioned message sometime during the night. If we set the extent of the 10x10 km area - we get results in under a minute. Since we do not want to use application-level environment settings where calculations are only based on a specific extent/display extent, the extent calculation should be coded inside the models.

This is a general issue and it appears in both - Pro and ArcMap Military Tools

3. What are the benefits or changes that would result from the enhancement? (i.e. How does making this change help the customer's workflow or business?)

This would help improve the stability of the tool when working with rasters that have large extents.
Product: ArcGIS for Desktop
Functional Category: ArcGIS for Defense
Client Platform: (n/a)
Version Found: 10.5
Planned Version Fixed: (n/a)
Comment: (n/a)
kgonzago commented 7 years ago

Limitation will be doc'ed for this release and issue will be addressed in next release.

FYI @nfeuerstein @topowright @lfunkhouser

topowright-zz commented 7 years ago

After reading the documentation that is provided by core we decided not to list this in our documentation. It would be a plus if we were able to address this issue in future releases by thinking about the extent of the analysis for the user; however, there are not actions for this release. I am switching this to as designed, enhancement and version after next.

topowright-zz commented 7 years ago

@nfeuerstein I think we are putting everything to version after next and then you would figure out what is going to be addressed in our next release. If this is not the case please excuse the mistake.

lfunkhouser commented 6 years ago

Removing As Designed label - This label is reserved for closing an issue because we will not address it due to the intended way the feature was designed. It is an enhancement request logged by a customer that we will investigate further.

topowright-zz commented 6 years ago

I think we should calculate based on the extent based on the information put in by the user. The challenge is when a user selects two areas that are not close to each other, but are still small request areas.

topowright-zz commented 6 years ago

This would be a great candidate to create a unit test for.

topowright-zz commented 6 years ago

This is the image service that I tested against: http://lidar.geodata.md.gov/imap/rest/services/Allegany/MD_allegany_dem_m/ImageServer

topowright-zz commented 6 years ago

Thinking about this further we need to understand the cost of the clip. Does it make sense to have each iteration clip the raster or one large clip. This has been tested with image services, but we need to test this on a large mosaic dataset.

topowright-zz commented 6 years ago

We also need to understand how LLOS and RLOS are conducting the analysis. @BobBooth and @csmoore are experiencing the same thing I am, which is one is faster than the other.

topowright-zz commented 6 years ago

RLOS is the slower one.

topowright-zz commented 6 years ago

Added information to the first part of this issue. We need to change the RLOS workflow to mimic the LLOS workflow if that is not the case.

lfunkhouser commented 6 years ago

Research What does ArcGIS (ArcMap and ArcGIS Pro) do when the processing extent is outside of the raster extent Is this related to a service or local raster dataset Is this an add-in or GP problem