search

Esri / visibility-addin-dotnet

ArcGIS Add-in provides the capability to quickly do line of sight analyses.
Apache License 2.0
14 stars 19 forks source link

BUG-000107342 There is a typographical error in Viewshed.py script from the Military Tools for ArcGIS 10.5.1 #223

Closed lfunkhouser closed 6 years ago

lfunkhouser commented 7 years ago
Salesforce ID: BUG-000107342
Salesforce Submitter: Emad Mohammed
Salesforce Submit Date: 8/14/2017 9:06 AM
Salesforce Bug Type: Failure/Error
Salesforce Severity: Medium
Repro Data: (n/a)
Work Around: (n/a)
Product: ArcGIS for Defense
Functional Category: ArcGIS for Defense
Client Platform: (n/a)
Version Found: 2.0 Beta
Planned Version Fixed: (n/a)
Comment: (n/a)

Steps to Repro: Using Military Tools for ArcGIS 2.0 with Portal/Server 10.5.1 when setting up the visibility geoprocessing service on a closed system, the user noticed a small typo in the Viewshed.py script. The typo is on line 183, and reads: arcpy.env.mask = "in_memory\OutBuffer" It should read: arcpy.env.mask = "in_memory\OuterBuffer". The "er" is missing from the end of the line between "Out" and "Buffer". Kindly refer to the following link: https://solutions.arcgis.com/defense/help/military-tools/web-appbuilder/set-up-elevation-geoprocessing-service.htm

joebayles commented 7 years ago

Has anyone talked about this? What is the typographical error?

topowright-zz commented 6 years ago

I have verified that this was fixed in Military Tools for ArcGIS 1.1, which was released in May 2017

lfunkhouser commented 6 years ago

@topowright This issue was reported on Military Tools for ArcGIS 2.0 - was it an issue at 1.0, fixed at 1.1 but reintroduced at 2.0?

csmoore commented 6 years ago

I wasn't aware of us fixing this until #246 - https://github.com/Esri/visibility-addin-dotnet/pull/246/files - I wasn't aware there was an open issue associated with this, so sorry for not linking to this in the PR

topowright-zz commented 6 years ago

@joebayles the issue was a typo where we were missing the er in the word outer. @lfunkhouser the issue is present in 1.1 and 2.0. My mistake on the comment above. The issue has been fixed based on the pull request referenced by @csmoore above.

lfunkhouser commented 6 years ago

Comment to support: This is verified as fixed and will be fixed in the next release of Visibility and Military Tools for ArcGIS.