Esri / visibility-addin-dotnet

ArcGIS Add-in provides the capability to quickly do line of sight analyses.
Apache License 2.0
14 stars 19 forks source link

In order to support LLOS and RLOS in Globe scenes, enable the addin to work with GCS WGS 84 #308

Open BobBooth opened 6 years ago

BobBooth commented 6 years ago

The addin works when the data frame and DEM data share the same projection. The data must be in a projected coordinate system for LLOS and RLOS to work. When you convert a 2D map in Pro 2.2 or 2.3 into a Global Scene, the default coordinate system is set to GCS WGS 84 and it is not possible to change this coordinate system in Global Scenes. image

Current Behavior

The addin warns that the spatial reference of the Data Frame and surface do not match. image Then it gives an error that the LLOS computation did not complete correctly. image

While this is better than failing without an error message, or crashing, we should be able to do better. I suggest that we enable the LLOS and RLOS tools to use a DEM that is projected, even if the current coordinate system of the data frame is different. This would involve reprojecting the input points and doing the calculation in the coordinate system of the DEM.

csmoore commented 5 years ago

I believe @dfoll had also mentioned after Fed GIS (because of problems he saw someone have during a demo) if we should require (versus warn) that the surface, input points, and map/data frame be in the same projection. Related to #306

BobBooth commented 5 years ago

I think it would make sense to project the input point features to match the raster, if the scene is in GCS WGS84. @dfoll @csmoore