search

Esri / visibility-addin-dotnet

ArcGIS Add-in provides the capability to quickly do line of sight analyses.
Apache License 2.0
14 stars 19 forks source link

Visibility and Coordinate Conversion crashing when invalid coordinates pasted #309

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

Testing the latest build of the Visibility and Coordinate Conversion stand alone add-ins, on Pro (2.3.0_15735) and ArcMap (10.3.1) I have found a crash when certain values are pasted into the input box (the addins work fine for adding points by clicking on the map).

If I set the coordinate system for the map by adding the "ElevationUTM_Zone10" from solutions test catalog data, in MilitaryToolsTestData.gdb and click on the map with the identify tool, I get values in our AOI such as: (in ArcMap) 647,071.585 4,037,740.468 Meters 647,771.497 4,035,832.642 Meters or (in Pro) 624,927.73E 4,045,489.61N m 627,776.94E 4,043,909.37N m image

DD and UTM values do not crash.

If I use these values as inputs for the LLOS, RLOS, and Coordinate Conversion input boxes, ArcGIS Pro (daily 2.3.0_15735), and ArcMap (10.3.1) both crash. I installed the previous versions of the addins [server]\Commercial\Solutions\DefenseSolutions and tested the September, August, and June 2018 builds. September and August had the crash, but the latest June build does not.

BobBooth commented 5 years ago

@kgonzago @dfoll @lfunkhouser @csmoore - coordinate conversion crash found, also affects visibility The 10/16/18 build of Distance and Direction (in December2018) is not affected.

BobBooth commented 5 years ago

Opened issue https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/547 Closing this one.

csmoore commented 5 years ago

I was not able to reproduce a crash in coordinate-conversion-addin-dotnet - but I was able to identify a possible source of the crash in Visibility.

Reopening issue and addressed in PR #310

dfoll commented 5 years ago

Tested using Visibility build 32 build from this feature branch

This looks to be fixed with ArcGIS Pro 2.3.0.15723 the add-in displays that coordinates you entered in the input box are invalid. If you press Enter to try to use those coordinates, you get a message that the coordinates are out of bounds.

image

This still needs to be fixed with ArcMap 10.3.1 the add-in displays that coordinates you entered in the input box are invalid. If you press Enter to try to use those coordinates, ArcMap crashes.

BobBooth commented 5 years ago

Tested in ArcMap 10.3.1 (4959) - this workflow still crashes in ArcMap. @csmoore

dfoll commented 5 years ago

Repro steps

  1. Open ArcGIS Pro
  2. Open the Visibility pane
  3. Set your input elevation service to ElevationUTM_Zone10
  4. Paste 10SFF2275043201 as your observer location
  5. Press Enter to register the coordinate to the list
  6. Paste 10SFF6034636466 as your target location
  7. Press Enter to register the coordinate to the list
  8. Click OK analysis runs correctly
  9. Press Cancel to completely clear all coordinates
  10. Paste 10SFF6034636466 as your target location
  11. Press Enter to register the coordinate to the list
  12. Paste 10S FF 22750 4320 as your observer location _note that it displays an "Invalid coordinate" warning.
  13. Press Enter to register the coordinate to the list An error displays saying the coordinate is out of bounds we're all good so far, this looks fixed for Pro
  14. Open ArcMap
  15. Open the Visibility pane
  16. Set your input elevation service to ElevationUTM_Zone10
  17. Paste 10SFF2275043201 as your observer location
  18. Press Enter to register the coordinate to the list
  19. Paste 10SFF6034636466 as your target location
  20. Press Enter to register the coordinate to the list
  21. Click OK analysis runs correctly
  22. Press Cancel to completely clear all coordinates
  23. Paste 10SFF6034636466 as your target location
  24. Press Enter to register the coordinate to the list
  25. Paste 10S FF 22750 4320 as your observer location _note that it displays an "Invalid coordinate" warning.
  26. Press Enter to register the coordinate to the list Instead displaying an error like ArcGIS Pro, ArcMap crashes
BobBooth commented 5 years ago

image

csmoore commented 5 years ago

@dfoll @BobBooth - I can reproduce and see the issue, I will add to the PR #310 in a few mins

csmoore commented 5 years ago

@dfoll @BobBooth - PR #310 has been updated for ArcMap - please retest - sorry, not sure how I missed that

dfoll commented 5 years ago

Retested these repro steps

BobBooth commented 5 years ago

This works with latest test build in ArcMap.

dfoll commented 5 years ago

Rebuilt MT (176) with the recent changes and this looks good