search

Esri / wind-js

An demo animation of wind on a Canvas layer in the JSAPI
MIT License
739 stars 214 forks source link

Better resolution on the edges #27

Closed fullergalway closed 7 years ago

fullergalway commented 7 years ago

Use the properties of the current vector when the target vector is blank.

jgravois commented 7 years ago

thanks for the contribution!

what specific situation does this trap for? the new codeblock isn't accessed when i load the page and pan and zoom a bit.

fullergalway commented 7 years ago

Hi John,

I'm trying windy to model sea surface movement; I found that the visualisation to be missing detail at the waters edge when motion was towards shore. Does this make sense?

Thanks, Rob.

jgravois commented 7 years ago

forgive me if its a dense question, but how can i most easily go about testing the impact of your changes?

fullergalway commented 7 years ago

Hi John,

Thanks for this. I followed up by creating a test gfs.json which I expected to trigger the new code block. It did not. I apologise for the inconvenience and am closing this pull request.

Thanks again, Rob.

jgravois commented 7 years ago

I apologise for the inconvenience and am closing this pull request.

no need to apologise. if you can add an inline code comment as a breadcrumb to explain the effect, i'd be satisfied to merge it.

fullergalway commented 7 years ago

As I wasn't able to trigger the block of code using my test data it's probably best to close/cancel the merge request. If I'm able to demonstrate then I'll open a new merge request and include the test case. Thanks again.