search

Esri / wind-js

An demo animation of wind on a Canvas layer in the JSAPI
MIT License
735 stars 214 forks source link

Fork/PR #6

Closed tmcw closed 10 years ago

tmcw commented 10 years ago

This would be a great contribution back to the main /earth repository, and if it was a fork, it would be clearer to users that it is adapted from that project. Could this be redone as a contributable chunk rather than a cp?

chelm commented 10 years ago

Totally should be. Its really a question of the amount of changes that the original would need to support this and of course the time it would take to overhaul the entire app. Earth is great but its heavily intertwined with itself in terms of UI events and the interaction of the grid algorithms.

I'll spend some time thinking about it some more because I'd love to have it contributed back in. There are a few things this code loses in terms of features (d3 projections for one) and the ability to support different grid types among others. But here at least we gain a bit more flexibility in terms of how we can apply the code.

ghost commented 10 years ago

I'd agree with Christopher here. It's so different from Cameron's work that it would difficult for both.

tmcw commented 10 years ago

Okay, so if the 'cp' instead of fork idea is what you're going to do, I would recommend:

Otherwise this feels very high on my 'icky appropriation of open source code where you could be contributing and most of your users will misassign credit' meter.

chelm commented 10 years ago

Not trying to mis-assign credit, will change the license and remove all the boilerplate readme copyright stuff.

JoshData commented 9 years ago

A hat tip to http://hint.fm/wind/ for inventing this type of visualization would be a good idea too.