search

EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
52 stars 8 forks source link

🖼 Invalid Image Links Bug Fix #24

Closed Iten-No-404 closed 7 months ago

Iten-No-404 commented 7 months ago

Issue 23 As can be seen in the image above, the links to profile pictures in LinkedIn are subject to constant change and so, the links should be checked for validity before they are displayed in the website.

EssamWisam commented 7 months ago

Saw this earlier and thought it was browser dependent. I have Edge and Safari and on Safari, the images would not appear to be squished.

Nonetheless, this is an ideal solution to the problem. I tried to see if there is an automatic way to have them updated but LinkedIn's API does not give access to profile pictures.

Thanks.

Iten-No-404 commented 7 months ago

on Safari, the images would not appear to be squished.

Interesting.

if there is an automatic way to have them updated

There must be a way somehow. If I find one, I'll be sure to do a PR.

Thanks.

You're welcome.

EssamWisam commented 7 months ago

There must be a way somehow. If I find one, I'll be sure to do a PR.

I assure you that according to my research, there isn't. It requires being logged in to the account holding the profile picture.