search

EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
52 stars 8 forks source link

🪲 Bug regarding squished images #29

Closed EssamWisam closed 4 months ago

EssamWisam commented 7 months ago

image

I sometimes find unloaded images as in the image above, especially in the other classes' pages. Checked out previous PRs and it seems like that the problem was there from the beginning, we just didn't notice it. So, I would assume that the invalid images are from the website that creates these placeholder images. Not sure if we should check for that as well or just opt for reloading the page (and so getting another seed which will highly be a valid image).

Originally posted by @Iten-No-404 in https://github.com/EssamWisam/cmp-docs/issues/28#issuecomment-1815008814_

EssamWisam commented 7 months ago

we can either check for the validity of the placeholder image or use another placeholder website.

Will explore solutions to this problem. Could be that the server for the placeholder images is a little funny because to me this happens really inconsistently (switching pages or refreshing often makes it go) and sometimes it doesn't occur in the first place.

I would deprioritize looking for another one because I remember spending a reasonable amount of time looking for visually pleasing placeholder images, most of them were far inferior to this.

Iten-No-404 commented 7 months ago

Will explore solutions to this problem. Could be that the server for the placeholder images is a little funny because to me this happens really inconsistently (switching pages or refreshing often makes it go) and sometimes it doesn't occur in the first place.

You're right. It could possibly be their server or a mere connection issue. This issue has the least priority among all the other ones since it rarely happens.

EssamWisam commented 5 months ago

Looks like the virus is back!

image