search

EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
52 stars 8 forks source link

✨ Add English course descriptions for communication, other engineering and general sections #35

Closed EssamWisam closed 5 months ago

EssamWisam commented 5 months ago

Towards closing #13

A quick review would be appreciated @Iten-No-404 . I prioritizied getting over with these in this week because I know school starts in about two weeks and widely announcing the website soon should be helpful. In all cases, take your time with the ones you are working on.

netlify[bot] commented 5 months ago

Deploy Preview for cmp-docs ready!

Name Link
Latest commit 1145999593ee194ecf4cad41a7f2babf88051816
Latest deploy log https://app.netlify.com/sites/cmp-docs/deploys/65b531e387d0250008a9e429
Deploy Preview https://deploy-preview-35--cmp-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Iten-No-404 commented 5 months ago

A quick review would be appreciated @Iten-No-404 .

On it.

take your time with the ones you are working on.

I was actually working on the Maths group of courses right now, which is last remaining group. Should be done in an hour or so.

EssamWisam commented 5 months ago

I think I couldn't remember the professor name(s) for the electrical engineering course and could not find myself in the classroom so I left that empty. Likewise, I didn't emphasize being detailed on the content for general courses such as Presentations and Technical Writing because I know they have changed and probably prone to change again.

EssamWisam commented 5 months ago

Very few typos, but overall spectacular work as always.✨ Please check the comments and approve what you see fit.

Approved everything. Sorry for the typos, thought the VSCode extension I have was working and I was using fewer brain cells than average while wokring on this. Thank you so much.

EssamWisam commented 5 months ago

For some reason the deploy previous doesn't work on my side; despite that I remember witnessing it work just a few weeks ago or something. Does this also happen to you?

Edit: Okay, it randomly works. Just like the site only randomly works when accessed from Egypt. Will probably change Netlify because I thought that an index file I added earlier solved this.

Iten-No-404 commented 5 months ago

Sorry for the typos ... and I was using fewer brain cells than average while working on this. Thank you so much.

You're welcome. They weren't a lot anyway.

For some reason the deploy previous doesn't work on my side; despite that I remember witnessing it work just a few weeks ago or something. Does this also happen to you?

I don't think so. I tried the #2 deployment now and it was working fine as well as the preview for this PR.

Edit: Okay, it randomly works. Just like the site only randomly works when accessed from Egypt. Will probably change Netlify because I thought that an index file I added earlier solved this.

Okay, maybe create a new issue for this?