search

EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
52 stars 8 forks source link

[Content][ClassList] Add CCEC 24 (Credit) Class list #46

Closed Khalidmamdou7 closed 4 months ago

Khalidmamdou7 commented 4 months ago

Adding the Class list of the class of 2024 CCEC in both languages, marking one of the tasks in this issue #12 done.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 0:52am
netlify[bot] commented 4 months ago

Deploy Preview for cmp-docs ready!

Name Link
Latest commit 2528ed8d51ae4324fe81c1481e87ba33d2694779
Latest deploy log https://app.netlify.com/sites/cmp-docs/deploys/65c0d9c85667f30008224257
Deploy Preview https://deploy-preview-46--cmp-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EssamWisam commented 4 months ago

For purposes like #33, would be quite useful to include LinkedIn links. Perhaps, you plan to do that in a future PR? If so, I would still not recommend keeping the markdown field empty. Maybe write something like "This is one fantastic CMP student".

Khalidmamdou7 commented 4 months ago

For purposes like #33, would be quite useful to include LinkedIn links. Perhaps, you plan to do that in a future PR?

Unfortunately, not all my colleagues have provided their linekdin profiles, so I couldn't do it, only 4 of them have provided it. Hopefully on the future they will provide it.

If so, I would still not recommend keeping the markdown field empty. Maybe write something like "This is one fantastic CMP student".

I have added this default value for the markdown

EssamWisam commented 4 months ago

Alright. Time to merge this now. Thank you so much for the contribution.

Unfortunately, not all my colleagues have provided their linekdin profiles, so I couldn't do it, only 4 of them have provided it. Hopefully on the future they will provide it.

Ideally, you assume no one will be not lazy to provided it and that you do have them all in your connections (and can easily reach the missing ones by search). That's what I believe we had done. It may seem like a lot but I doubt it takes more than 30-60 minutes.