search

EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
57 stars 8 forks source link

⏰ Reminder to Run LinkedIn Scraper #55

Closed github-actions[bot] closed 6 months ago

github-actions[bot] commented 6 months ago

It's been two weeks.

EssamWisam commented 6 months ago

@Iten-No-404 I made and tested the Github action to remind us to run the script every two weeks. This is an example issue from the bot.

I was thinking that it's better to write the steps for how run the script in the body instead of just "It's been two weeks". Could you go here and add instructions for that please?

Thank you.

I also think we should reset this on Saturday or some weekend day because reminding on Tuesday not gonna be so helpful.

Iten-No-404 commented 6 months ago

@EssamWisam, great! I'll edit the workflow yaml file so that it sends the reminder every 2 weeks on Saturday on 7 am for example. And I'll add the steps to run the script to the linked markdown file.

Iten-No-404 commented 6 months ago

@EssamWisam, I finished adding the steps for running the script. You can check it out #56 and here.

I have a small note though. It seems like cron expressions don't have the capability to run every other week. So, we can make it every first and third Saturday of every month which should handle most cases and run every 2 weeks, but it could be 3 weeks in some cases and its cron expression is 0 7 1-7,14-21 * 6.

If you are okay with this, I'll create a PR to add these changes and the GitHub reminder shouldn't trigger until 15/6/2024 since that will be the third Saturday. Note that the first Saturday should have triggered on 1/6/2024 but it has already passed. So, let's assume this is the one generated in its stead. I will run the script on all the classes and update them to close this instance of the issue.

EssamWisam commented 6 months ago

So you're saying that ChatGPT failed to write for me the correct cron expression for two week repetition and it's not doable. Alright. Thank you so much for noticng and for the perfect resolution.

Iten-No-404 commented 6 months ago

So you're saying that ChatGPT failed to write for me the correct cron expression for two week repetition and it's not doable.

Yes, I tried using ChatGPT and Gemini. The ChatGPT one actually runs every 2 days as you may have noticed this issue #57. Since both returned different answers, I googled it instead.

I will close this issue and leave #57 for submitting the results of the latest script run.

EssamWisam commented 6 months ago

Like the double validation strat. I usually go to Gemini only if it's obvious ChatGPT failed. Thanks.