EssamWisam / cmp-docs

A comprehensive guide for prospective, current and past students in the computer engineering department of Cairo university.
https://cmp-docs.pages.dev
52 stars 8 forks source link

✨ Add Opportunies Section #61

Closed EssamWisam closed 3 weeks ago

EssamWisam commented 3 weeks ago

This PR introduces the following new developments:

In particular, I was motivated to work on these three items after going through relevant experiences for them. Dr. Dina Tantawy's slides assisted in "Teaching Opportunities" and Eng. Mohamed Hadidy in the graduate studies page for German MS and aside from making a new GSoC video, I linked the previous ones.

To who may be reviewing this. You need not do this with great detail for your time and because I would be happy to have this out by tomorrow. Thank you.

I intentionally left the Arabic versions empty. Good to have more tasks like this in the issues section to encourage contribution as summer vacation in two days or so.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 7:05pm
netlify[bot] commented 3 weeks ago

Deploy Preview for cmp-docs ready!

Name Link
Latest commit 3b10e392d1363ff9814237c29c4d9e4329e5b135
Latest deploy log https://app.netlify.com/sites/cmp-docs/deploys/66674e6db53252000755ee1b
Deploy Preview https://deploy-preview-61--cmp-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-pages[bot] commented 3 weeks ago

Deploying cmp-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b10e39
Status: ✅  Deploy successful!
Preview URL: https://37a83802.cmp-docs.pages.dev
Branch Preview URL: https://opportunities-pages.cmp-docs.pages.dev

View logs

Iten-No-404 commented 3 weeks ago

@EssamWisam, this was a compelling read for sure. Excellent work as always, thank you!

I didn't find many typos or grammar mistakes.

I have 2 trivial comments in the review that aren't proofreading related. (The only 2 that aren't resolved yet) Feel free to address them or ignore them.

The only comment I have regarding the content itself is that we could add details about USA's VISA since that for Germany's was mentioned.

I have also modified the react code to accept HTML Markdown syntax for non-grid pages to enable anchor links which I thought would be a nice touch for the Graduate Studies page and maybe other future pages.

All in all, I think this PR is ready for merging and I'll create new issues for translating the pages to Arabic.

EssamWisam commented 3 weeks ago

@EssamWisam, this was a compelling read for sure. Excellent work as always, thank you!

Happy to hear the positive feedback. Thank you.

The only comment I have regarding the content itself is that we could add details about USA's VISA since that for Germany's was mentioned.

I was writing the U.S. section based on my own experience and it didn't involve any VISA interaction because of holding a passport. In any case, I think the VISA should hopefully be straightforward should someone be accepted because there shouldn't be a financial requirement like Germany (since full funding is guaranteed by university).

I have also modified the react code to accept HTML Markdown syntax for non-grid pages to enable anchor links which I thought would be a nice touch for the Graduate Studies page and maybe other future pages.

I didn't understand the need for this to be honest. Markdown supports anchors with ![name](link) as you know.

Iten-No-404 commented 3 weeks ago

Happy to hear the positive feedback. Thank you.

You're very welcome.

I was writing the U.S. section based on my own experience and it didn't involve any VISA interaction because of holding a passport. In any case, I think the VISA should hopefully be straightforward should someone be accepted because there shouldn't be a financial requirement like Germany (since full funding is guaranteed by university).

Okay, no worries.

I didn't understand the need for this to be honest. Markdown supports anchors with ![name](link) as you know.

I added it for supporting anchors/links to the page headers and not external links (which are already supported by ReactMarkdown). For example in the Graduate Studies page, you can click on the Graduate Studies at Cairo University at the top of the page, you are scrolled down to the respective section. This can be done by adding an component beside the header.

## 🇪🇬 Graduate Studies at Cairo University<a id='CUFE'></a>

While the link can be written as

[Graduate Studies at Cairo University](#CUFE) 

I think there's supposedly another way to do this by writing the title of the header in a specific way without the use of HTML as:

[Graduate Studies at Cairo University](#-graduate-studies-at-cairo-university)

However, it didn't work when I tried it out.

EssamWisam commented 3 weeks ago

That's so clean. Thank you so much. Merging now.