EssentialsX / Essentials

The modern Essentials suite for Spigot and Paper.
https://essentialsx.net
GNU General Public License v3.0
1.95k stars 983 forks source link

Curses with essentials.keepinv #3219

Closed kaanakduman closed 4 years ago

kaanakduman commented 4 years ago

Feature request

Feature description Add configuration options to

  1. Make items with curse of vanishing disappear on death, even if the player has essentials.keepinv
  2. Make items with curse of binding drop on death, even if the player has essentials.keepinv

How the feature is useful Curse of vanishing is supposed to disappear when the player dies. However, if the player has essentials.keepinv, then the player keeps their inventory, essentially making the enchantment pointless.

Curse of binding is supposed to be unremovable except by either the player dying or the durability reaching 0. However, if the player has essentials.keepinv, then the only way that the player can remove an item with binding is by allowing the durability reach 0. This means getting attacked a lot and potentially dying multiple times. This can spam the server with death messages, and it's even worse if the armor has unbreaking or mending.

zml2008 commented 4 years ago

There are probably multiple ways to handle this, dunno which one is the most correct, but here's a few other alternatives

xHydration commented 4 years ago

What if keepinv was able to be toggled on and off by the player?

zml2008 commented 4 years ago

that is uh what permissions do