Can't click links in chat while EssentialsX is installed (default server + plugin setup)

Mangonels commented 2 years ago

Type of bug

Other unexpected behaviour

`/ess dump all` output

https://essentialsx.net/dump.html?id=51b491322d8e43889d8a60f098c3f119

Error log (if applicable)

No response

Bug description

While EssentialsX is installed on a Paper server, you can't click any chat hyperlinks.

I haven't tested this extensively, but it is posible some links are clickable, I just couldn't do it on my test server.

On my main server, some voting links are clickable, while or website's link isn't.

It doesn't seem to matter if the hyperlink is using the https://www., http://www, or mere www prefixes, the hyperlink block can still happen.

Steps to reproduce

Start a new 1.18.2 Paper server
Log into it and test hyperlinks in chat by writing a few website dns's.
Stop the server, install EssentialsX
Start the server, log into it and test hyperlinks in chat.

Expected behaviour

Hyperlinks should be clickable.

Actual behaviour

Hyperlinks are not clickable in step 4 because EssentialsX is installed. This has been tested by many diferent clients (on my main server), all of which had hyperlinks enabled in their config.

osfanbuff63 commented 2 years ago

Hmm, it works on my server, but my server uses VentureChat for chat and that is probably part of it.

Does it still happen if you install EssX Chat? I don't know if it will make a difference, but if this is a bug that would at least provide a workaround.

Mangonels commented 2 years ago

Hey, ok so, for starters, I've never used EssentialsXChat on any of my servers, just wanted to state that in case relevant. I'm using ChatControlRed on my main server for chat controlling.

I just added EssentialsXChat to the test server, so now I have EssentialsX and EssentialsXChat installed. EssentialsXChat seems to default remove the dots from any links written on the chat... so I couldn't click on links written in chat.

However, I used the server's /say command to paste a link, and I can't open it. Not sure if this is normal or not. I'm gonna remove both plugins just to confirm if it isn't normal. Edit: looks like it is normal for links pasted in say command not to work, so idk, anything else I can test?

osfanbuff63 commented 2 years ago

Hey, ok so, for starters, I've never used EssentialsXChat on any of my servers, just wanted to state that in case relevant. I'm using ChatControlRed on my main server for chat controlling.

I just added EssentialsXChat to the test server, so now I have EssentialsX and EssentialsXChat installed. EssentialsXChat seems to default remove the dots from any links written on the chat... so I couldn't click on links written in chat.

However, I used the server's /say command to paste a link, and I can't open it. Not sure if this is normal or not. I'm gonna remove both plugins just to confirm if it isn't normal. Edit: looks like it is normal for links pasted in say command not to work, so idk, anything else I can test?

Does EssXchat have a setting for it? ~~If not, I'm making a feature request for it unless it already exists~~

mdcfe commented 2 years ago

EssentialsX Chat will filter URLs from chat from any players who don't have the essentials.chat.url permission. You should grant this permission to anyone you want to be able to post clickable URLs in chat.

osfanbuff63 commented 2 years ago

EssentialsX Chat will filter URLs from chat from any players who don't have the essentials.chat.url permission. You should grant this permission to anyone you want to be able to post clickable URLs in chat.

AFAIK this report was created with the main plugin, but not EssXChat? And then I brought it up as a potential workaround.

Mangonels commented 2 years ago

The permission essentials.chat.url was already added on my main server.

Furthermore, I just installed LuckPerms to my local test server and explicitly added the permission to the default group.

Links still cannot be clicked.

Please reopen.

Mangonels commented 2 years ago

EssentialsX Chat will filter URLs from chat from any players who don't have the essentials.chat.url permission. You should grant this permission to anyone you want to be able to post clickable URLs in chat.

I didn't have EssentialsXChat installed on my local test server though (because I removed it, seeming as it was unnecesary). I also never used it on my main server, but links had always been fine.

This issue is present with Only EssentialsX installed (and now also LuckPerms with the specified perm node), as I mention on the main report, should I install EssentialsXChat though for any reason...? Edit: noticed adding EssXChat to my local test server does ineed solve the issue, still:

Kinda weird if I should install this considering I don't really need it, and haven't used it for like 2 years (since colored signs could be made in vanilla) and hyperlinks have worked just fine in that period... just to get something already present in MC Vanilla to work.

osfanbuff63 commented 2 years ago

EssentialsX Chat will filter URLs from chat from any players who don't have the essentials.chat.url permission. You should grant this permission to anyone you want to be able to post clickable URLs in chat.

I didn't have EssentialsXChat installed on my local test server though (because I removed it, seeming as it was unnecesary). I also never used it on my main server, but links had always been fine.

This issue is present with Only EssentialsX installed (and now also LuckPerms with the specified perm node), as I mention on the main report, should I install EssentialsXChat though for any reason...? Edit: noticed adding EssXChat to my local test server does ineed solve the issue, still:

Kinda weird if I should install this considering I don't really need it, and haven't used it for like 2 years (since colored signs could be made in vanilla) and hyperlinks have worked just fine in that period... just to get something already present in MC Vanilla to work.

You don't, it was me trying to find a workaround potentially (which it did). Although, if this is present with vanilla MC then it's an upstream issue.

Mangonels commented 2 years ago

It is not present in MC vanilla.

pop4959 commented 2 years ago

Can confirm on Paper-42 for MC 1.19 that links are not clickable on 2.19.5-dev+23-6816eb4 with Essentials installed, and then again clickable when both Essentials and EssentialsChat are installed.

Mangonels commented 2 years ago

Installing WorldGuard with WorldEdit (just these two, and not reproduceable with only WorldEdit), on a clean server also reproduces the same exact issue I describe on this ticket.

We notified worldguard.

There may be other plugins that when installed on their own can trigger this issue. WG and EssX have in common that they do handle chat in certain ways (WG has that chat based flag toggling system), so maybe plugins causing this do so by manipulating chat stuff.

Maybe a Spigot/Paper bug with the API when handling chat?

osfanbuff63 commented 2 years ago

Installing WorldGuard with WorldEdit (just these two, and not reproduceable with only WorldEdit), on a clean server also reproduces the same exact issue I describe on this ticket.

I notified WG.

There may be other plugins that when installed on their own can trigger this issue. WG and EssX have in common that they do handle chat in certain ways (WG has that chat based flag toggling system), so maybe plugins causing this do so by manipulating chat stuff.

Maybe a Spigot/Paper bug with the API when handling chat?

Can you try a Spigot 1.19 server to see? If not, it could be Paper's problem or a plugin problem (but I doubt that). If so, I don't know - then it could be Spigot's problem, or somehow Paper's problem still, or a problem with the Bukkit API, or just a plugin problem :P

(Also, I would test myself, but my PC isn't great for that :P)

Also, can you link to the WG issue you created? e.g. EngineHub/WorldGuard#nnnn (replace #nnnn with the issue number)

Mangonels commented 2 years ago

Sorry, I don't have any 1.19 test servers available, since I don't plan on updating to this version any time soon.

WG ticket: https://github.com/EngineHub/WorldGuard/issues/1929

osfanbuff63 commented 2 years ago

Oh sorry, I meant 1.18.2, I forgot that you are running it :P

JRoy commented 2 years ago

I have no idea wtf is going on here 😬

Mangonels commented 2 years ago

I have no idea wtf is going on here 😬

Did you try my "steps to reproduce" and get the same results? If you couldn't get the same results, I will try on a diferent machine or something ._.

JRoy commented 2 years ago

I have no idea wtf is going on here 😬

Did you try my "steps to reproduce" and get the same results? If you couldn't get the same results, I will try on a diferent machine or something ._.

No 😄, I mean I have no idea how this is happening. I'll probably have to save this for the chat system rewrite I'm planing in 2.20.0

Klawdek commented 1 year ago

No clickable links at all. No discord links. That is ruination for a server. 😖

Kxsumi commented 1 year ago

I believe this was confirmed to be a Paper issue somewhere. (I believe it was on r/admincraft)

Mangonels commented 1 year ago

No clickable links at all. No discord links. That is ruination for a server. 😖

Some links do actually work on our server somehow, I'd say it's just the ones that are being displayed by ChatControlRed.

I believe this was confirmed to be a Paper issue somewhere. (I believe it was on r/admincraft)

Sadly we are planning on staying on Paper for mc 1.18.2's last build, support for mc 1.18 was officially dropped around 6 months from 1.19's release. So we are kinda stuck in this situation until we update, which we are not in a hurry to do for any reason except for solving this issue (and then getting a ton of new bugs in from 1.19).

JRoy commented 1 year ago

So turns out Paper has removed this functionality from chat messages and other plugins using legacy strings to send messages to clients. This will need to be considered as part of our chat system rewrite after adventure support is added.

revalenza commented 1 year ago

i'm playing on a 1.20.1 paper with essentialsx with chat and luckperms with essentials.chat.url and essentials.msg.url, clicking links only works on /broadcast and direct /msg. Normal chat, /say and automessage plugins cant be clicked. Disabling all plugins and datapacks and doesnt work in any case.

Tsoccerguy3 commented 1 year ago

Here is an example of a clickable link in a command block . edit it to your needs

/tellraw @p {"text":"https://www.google.com","clickEvent":{"action":"open_url","value":"https://www.google.com"}}

SKevo18 commented 10 months ago

i'm playing on a 1.20.1 paper with essentialsx with chat and luckperms with essentials.chat.url and essentials.msg.url, clicking links only works on /broadcast and direct /msg. Normal chat, /say and automessage plugins cant be clicked. Disabling all plugins and datapacks and doesnt work in any case.

I have the same issue - /me links can be clicked, but not chat or /say ones. Does anyone have any workaround for this? I can't look this up on the internet, because noone seems to be talking about this outside of this thread?

EssentialsX / Essentials