Esser50K / 90sYouTube

YouTube if you have 90s goggles on
1 stars 0 forks source link

Added featured videos below main vid on watch page #11

Closed matedyl closed 2 years ago

matedyl commented 2 years ago

Extracted fetchRecommendation function to separate file for reusability Extracted types to d.ts files for reusability

8

Esser50K commented 2 years ago

This PR got conflicts now with the master branch after the last merge so I cannot test it anymore @matedyl

matedyl commented 2 years ago

This PR got conflicts now with the master branch after the last merge so I cannot test it anymore @matedyl

@Esser50K conflicts resolved

Esser50K commented 2 years ago

I think this has a few bugs like the "loading..." appearing over the video thumbnails. Also the recommendations jump down after the video starts because it then fills up the empty space.

Also clicking a new video from the recommendations makes the backend render both videos at the same time while the audio is still from the first one - But I think this is more of a techincal issue I can solve later