search

Esser50K / 90sYouTube

YouTube if you have 90s goggles on
1 stars 0 forks source link

90fy it a bit more #18

Closed Esser50K closed 2 years ago

Esser50K commented 2 years ago

I added boxShadow on pretty much everything..

I changed the colors a bit. So to match youtube I would like the appbar and the drawer to have the same background color. But I'm having issues in getting it right for every style without breaking things, so for now it only is on the default youtube theme and poster. @matedyl maybe we can look at this together in a call.

Could you also review it because I'm not sure I'm following best practices and maybe I'm making it a mess again

matedyl commented 2 years ago

@Esser50K, I see that you're trying to replace the shadows array on theme level with a generated stacked boxShadow CSS prop on the component level. The purpose of shadows array is to define shadows assigned to different UI elements, so you need to keep it (you could generate it too if you'd like). Otherwise there will be inconsistent box shadows on different UI elements on default or hover states.

Let's discuss this on the next call. I will be ready for it on Thursday but I could also do Friday, so feel free to book it! :)