Estete9 / my-things-catalog

A console app that will help you to keep a record of different types of things you own: books, music albums, movies, and games.
MIT License
3 stars 0 forks source link

My Things catalog Kanban #21

Open Estete9 opened 10 months ago

Estete9 commented 10 months ago

3-person team

Member 1: @Estete9 Member 2: @eamador1 Member 3: @joramot

Kanban link: https://github.com/Estete9/my-things-catalog/projects/1

Gambit142 commented 10 months ago

Hi @Estete9 @joramot @eamador1 👋,

Good job so far!

Highlights

You still need to work on some issues to go to the next project, but you are almost there!

Required Changes ♻️

Screenshot 2023-12-04 230741

Please ensure that all cards have descriptions that match their headers. 🖱️ 😎

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.

You can also consider the following:

N/A

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please tag me in your question so I can receive the notification. You can tag me by typing @Gambit142

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.

ridwanediallo commented 10 months ago

STATUS: APPROVED 🟢

Hi team,

Congratulations!GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

(Highlights) Good Points: :+1:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.