Estimote / Android-Proximity-SDK

Estimote Proximity SDK for Android
https://developer.estimote.com
MIT License
82 stars 42 forks source link

App Bundle fails to build because of duplicate ic_launcher #91

Open jamieadkins95 opened 5 years ago

jamieadkins95 commented 5 years ago

Prerequisites

Basic information

Estimote SDK version: 1.0.3]

Android devices affected: N/A

Android OS version affected: N/A

Beacon hardware version: N/A

Description

When building an Android App Bundle I get an exception that says multiple ic_launchers have been declared with different content. I can see that com.estimote.ketchup has a ic_launcher. Is this needed?

I can work around this issue by just renaming my ic_launcher to something else, but it's not obvious what is happening when this error occurs, so it'd be great to avoid this altogether by deleting your unneeded ic_launcher.

(Optional) Steps to reproduce:

  1. Declare an ic_launcher in your app
  2. Build an app bundle /gradlew bundleDebug

Expected behavior: Estimote SDK should not declare a ic_launcher

Actual behavior: Estimote SDK declares an ic_launcher

Additional information

* What went wrong:
Execution failed for task ':coreapplication:packageDevDebugBundle'.
> java.util.concurrent.ExecutionException: com.android.tools.build.bundletool.exceptions.ValidationException: Modules 'beacons' and 'base' contain entry 'res/mipmap-mdpi-v4/ic_launcher.png' with different content.
jamieadkins95 commented 5 years ago
Screenshot 2019-04-14 at 00 24 24
SyedSaadUrRehman-MAD commented 4 years ago

yes this is a severe bug, It occurred to me only while signing the bundle and bundle has

in the manifest. In my case i have an icon named ic_date only in the base project, dynamic bundle res folder was empty. the error i got was same, I RENAMED the ic_date to ic_cal_date. After this change, i have another icon named "ic_time.png", followed same steps and i got my bundle.aab. I deduced that these names of icons are already TAKEN and we should not use such names.

LokmaneKrizou commented 3 years ago

Hi @jamieadkins95 , have you been able to solve this issue, we have similar issue, two libraries have the same resource name