search

Estimote / iOS-Fleet-Management-SDK

Estimote Fleet Management SDK for iOS
https://developer.estimote.com
MIT License
1.18k stars 398 forks source link

Daver/emoji explorer/error handling #243

Closed daverPL closed 7 years ago

daverPL commented 7 years ago

This change is Reviewable

przemekblasiak commented 7 years ago

Examples/swift/EmojiAdvertiser/EmojiAdvertiser/EmojiScanner.swift, line 140 at r1 (raw file):

extension EmojiScanner: Error {

    enum EmojiScannerError: Int {

You should inherit from Error HERE

Comments from Reviewable

przemekblasiak commented 7 years ago

Examples/swift/EmojiAdvertiser/EmojiAdvertiser/NearestEmojiVC.swift, line 1 at r1 (raw file):

//  Copyright © 2016 Estimote. All rights reserved.

Could you update headers in all files?

Comments from Reviewable

przemekblasiak commented 7 years ago

Examples/swift/EmojiAdvertiser/EmojiAdvertiser/EmojiScanner.swift, line 140 at r1 (raw file):

Previously, bprzemyslaw (Przemyslaw Blasiak) wrote…
You should inherit from Error HERE

I mean implement the protocol :D

Comments from Reviewable

przemekblasiak commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

przemekblasiak commented 7 years ago

Reviewed 8 of 8 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

przemekblasiak commented 7 years ago
:lgtm:

Comments from Reviewable

daverPL commented 7 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Examples/swift/EmojiAdvertiser/EmojiAdvertiser/EmojiScanner.swift, line 140 at r1 (raw file):

Previously, bprzemyslaw (Przemyslaw Blasiak) wrote…
I mean implement the protocol :D

Done.

Examples/swift/EmojiAdvertiser/EmojiAdvertiser/NearestEmojiVC.swift, line 1 at r1 (raw file):

Previously, bprzemyslaw (Przemyslaw Blasiak) wrote…
Could you update headers in all files?

Done.

Comments from Reviewable