Closed konradsopala closed 6 years ago
Reviewed 2 of 3 files at r1. Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions.
Examples/README.md, line 42 at r1 (raw file):
- **Loyalty** (Swift only, requires Estimote Beacons with the 4th-gen firmware, 4.x+) > Uses: Proximity beacons, beacon monitoring
Few suggestions: "beacon monitoring" -> "Estimote Monitoring" "Proximity beacons" -> "Estimote Proximity Beacons"
Examples/README.md, line 44 at r1 (raw file):
> Uses: Proximity beacons, beacon monitoring Cashier-customer app that allows cashiers to see customers at checkout in their iPad app and grant them their bonus points for their shopping. Completely new experience of earning points without carrying loyalty cards or scanning barcodes.
"grant them their bonus points" -> "grant them bonus points"?
Examples/swift/Loyalty/README.md, line 1 at r1 (raw file):
### Loyalty app
These two README.md
s (Loyalty and LoyaltyStore ones) look almost identical and we would have to update both of them each time we have a change to our dependency mechanism (we could use pods in other projects as well), so why not making it a chapter in the Examples/README.md?
(then these two README.md's wouldn't be needed anymore)
Comments from Reviewable
Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.
Examples/README.md, line 42 at r1 (raw file):
Few suggestions: "beacon monitoring" -> "Estimote Monitoring" "Proximity beacons" -> "Estimote Proximity Beacons"
Done.
Examples/README.md, line 44 at r1 (raw file):
"grant them *their* bonus points" -> "grant them bonus points"?
Yep. That's how it's written in the cloud that's why I thought it was correct. Changed
Examples/swift/Loyalty/README.md, line 1 at r1 (raw file):
These two `README.md`s (Loyalty and LoyaltyStore ones) look almost identical and we would have to update both of them each time we have a change to our dependency mechanism (we could use pods in other projects as well), so why not making it a chapter in the Examples/README.md? (then these two README.md's wouldn't be needed anymore)
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.
Examples/swift/Loyalty/README.md, line 1 at r1 (raw file):
Done.
Did you remove this one as well? It looks like you didn't or maybe Reviewable is messing things up?
Comments from Reviewable
Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.
Examples/swift/Loyalty/README.md, line 1 at r1 (raw file):
Did you remove this one as well? It looks like you didn't or maybe Reviewable is messing things up?
Done.
Comments from Reviewable
Reviewed 1 of 2 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
This change is![Reviewable](https://reviewable.io/review_button.svg)