EsupPortail / Esup-Pod

plateforme de gestion de fichier vidéo
https://pod.esup-portail.org/
GNU Lesser General Public License v3.0
36 stars 77 forks source link

[DONE] Fix bugfixes for 3.6.0 #1117

Closed AymericJak closed 6 months ago

AymericJak commented 6 months ago

Before sending your pull request, make sure the following are done :

AymericJak commented 6 months ago

Pour la 3.6.1, il faudra modifier cette condition dans les différents fichiers {% if USE_PLAYLIST and USE_FAVORITES %}.

Pour utiliser USE_FAVORITES, il faut obligatoirement avoir USE_PLAYLIST.

Dans le cas où USE_FAVORITES est à True et que USE_PLAYLIST à False : aucun effet --> il n'y a pas de playlist, donc pas de favoris.

:one: Donc dans les fichiers, soit modifier comme suit :

{% if USE_PLAYLIST %}
  <script src="{% static 'playlist/js/utils-playlist.js' %}?ver={{VERSION}}"></script>
  {% if USE_FAVORITES %}
    <script src="{% static 'playlist/js/video-list-favorites-card.js' %}?ver={{VERSION}}"></script>
  {% endif %}
{% endif %}

:two: Soit retirer le paramètre USE_FAVORITES.

gitguardian[bot] commented 6 months ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!