README updates - Githubissues

ericweiner commented 1 year ago

Currently it:

Is missing the Pylon driver requirement. Not sure if we can just include the small Basler driver? Maybe we can link that on the right?
We need to make an OSX version. Basically the same as Linux, but when you run it, you have to say "python3" instead of just python
Still has MCP2210 as a pip install. We should probably check and realign all of these pip installs (on the various platforms) so that they are more consistent.

(I will add more specifics to this issue over time)

EtalumaSupport commented 1 year ago

I can edit the README to include the Pylon driver. I guess an exe can't include it but an MSI can?

EtalumaSupport commented 1 year ago

Most customers are downloading the exe zip version

ericweiner commented 1 year ago

I was referring to the readme in GitHub, describing on how to install the python version.

ericweiner commented 1 year ago

We still need to clarify/update the readme to specify exactly what versions of everything that should be installed (for users that are using the .py version).

ericweiner commented 7 months ago

Jordan-

Is there a way to easily list all of the pip installs that we need to run LV Pro?

The readme file is very out of date.
I think we should probably all change the command so that it is a single one and has the “update” flag so that you can just run it anytime and get all of the latest.

jmcoreymv commented 7 months ago

Jordan-

Is there a way to easily list all of the pip installs that we need to run LV Pro?

The readme file is very out of date. I think we should probably all change the command so that it is a single one and has the “update” flag so that you can just run it anytime and get all of the latest.

I would recommend we update the readme to reference the requirements.txt file. This lists all the required python packages and their versions: https://github.com/EtalumaSupport/LumaViewPro/blob/main/requirements.txt

A user can install them all together by typing pip install -r requirements.txt

ericweiner commented 7 months ago

Oh that’s 100x better…

-E

On Feb 22, 2024, at 2:06 PM, jmcoreymv @.***> wrote:

Jordan-

Is there a way to easily list all of the pip installs that we need to run LV Pro?

The readme file is very out of date. I think we should probably all change the command so that it is a single one and has the “update” flag so that you can just run it anytime and get all of the latest.

I would recommend we update the readme to reference the requirements.txt file. This lists all the required python packages and their versions: https://github.com/EtalumaSupport/LumaViewPro/blob/main/requirements.txt

A user can install them all together by typing pip -r requirements.txt

— Reply to this email directly, view it on GitHub https://github.com/EtalumaSupport/LumaViewPro/issues/230#issuecomment-1960395116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZIHIDOS6E2OT3VNJGASM3YU66MXAVCNFSM6AAAAAAZEANM7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGM4TKMJRGY. You are receiving this because you modified the open/close state.

ericweiner commented 6 months ago

This looks good, I need to test.

We need to eliminate everything related to the MCP 2210. Probably pywinusb too, on Linux.
I will try this on OSX and see what we need to do there.

I think we can be using Python 3.11, there are some performance improvements in that. What version are you using there? (we had to wait for PyPylon to support it but now it does...) I will make this a separate issue. (The linux section mentions 3.10)

jmcoreymv commented 6 months ago

Updated README to eliminate mcp 2210 and pywinusb. Changes have been pulled into main branch.

EtalumaSupport / LumaViewPro

README updates #230