Open raphraph opened 8 months ago
EDIT: Fixed in 2340eeca88fab0b86f6e861c8267318f0f873b64.
There is a bug in the French strings.xml
: The tag <item quantity="one">
applies to both 0 and 1 in French. Therefore its value must not contain a hardcoded 1
but must instead contain a %d
format specifier. There is already a lint warning ImpliedQuantity on the relevant lines.
I've fixed the translation in Weblate. I guess the change will get to master somehow at some point. This is the change I did:
--- a/app/src/main/res/values-fr/strings.xml
+++ b/app/src/main/res/values-fr/strings.xml
@@ -22,22 +22,22 @@
<string name="date_time_fmt" msgid="1642972650061946484"><xliff:g id="date">%1$s</xliff:g>, <xliff:g id="time_interval">%2$s</xliff:g></string>
<string name="no_title_label" msgid="302177118061368042">"(Sans titre)"</string>
<plurals name="Nminutes">
- <item quantity="one">1 minute</item>
+ <item quantity="one"><xliff:g id="count">%d</xliff:g> minute</item>
<item quantity="many"><xliff:g id="count">%d</xliff:g> minutes</item>
<item quantity="other"><xliff:g id="count">%d</xliff:g> minutes</item>
</plurals>
<plurals name="Nmins">
- <item quantity="one">1 min</item>
+ <item quantity="one"><xliff:g id="count">%d</xliff:g> min</item>
<item quantity="many"><xliff:g id="count">%d</xliff:g> min</item>
<item quantity="other"><xliff:g id="count">%d</xliff:g> min</item>
</plurals>
<plurals name="Nhours">
- <item quantity="one">1 h</item>
+ <item quantity="one"><xliff:g id="count">%d</xliff:g> h</item>
<item quantity="many"><xliff:g id="count">%d</xliff:g> h</item>
<item quantity="other"><xliff:g id="count">%d</xliff:g> h</item>
</plurals>
<plurals name="Ndays">
- <item quantity="one">1 j</item>
+ <item quantity="one"><xliff:g id="count">%d</xliff:g> j</item>
<item quantity="many"><xliff:g id="count">%d</xliff:g> j</item>
<item quantity="other"><xliff:g id="count">%d</xliff:g> j</item>
</plurals>
@@ -353,7 +353,7 @@
<string name="preferences_pure_black_night_mode">Mode pure nuit noire</string>
<string name="no_reminder_label">Aucun</string>
<plurals name="Nweeks">
- <item quantity="one">1 sem.</item>
+ <item quantity="one"><xliff:g id="count">%d</xliff:g> sem.</item>
<item quantity="many"><xliff:g id="count">%d</xliff:g> sem.</item>
<item quantity="other"><xliff:g id="count">%d</xliff:g> sem.</item>
</plurals>
When the language of the system is set to french, the list that shows the possible reminder time available when editing the reminder of an event shows two "1 minute" entries and no "0 minute" entry.
I tried to look if it was a wrong translation, but I did not find a corresponding string with an error... but I'm not familiar with the tool so maybe my search was bad.