search

Etar-Group / Etar-Calendar

Android open source calendar
https://f-droid.org/packages/ws.xsoh.etar/
GNU General Public License v3.0
2.08k stars 393 forks source link

Untoggle "All day" leads to a 24h long event #289

Closed mueller-ma closed 6 years ago

mueller-ma commented 6 years ago

Steps to reproduce:

  1. Long press a day
  2. Press Edit
  3. Untoggle "All day"

Expected: Event starting on the day I pressed and ends on the same day

Actuall: Event starting on the day I pressed at 0:00 and ends next day at 0:00

Gitsaibot commented 6 years ago

Only happens in Monthview and when we use Long press instead of the Add event button. Long press is used to add an 24 event. So the question is why should we change that behavior ?

mueller-ma commented 6 years ago

Using long press is way faster than to use the fab and then select the date.

Gitsaibot commented 6 years ago

Si ;). At the moment I'm not sure if we will implement this. But if you want to do it for yourself here is what needs to be changed: In CreateEventDialogFragment.java at Line 145

mController.sendEventRelatedEventWithExtraWithTitleWithCalendarId(this, EventType.CREATE_EVENT, -1, mDateInMillis, mDateInMillis + DateUtils.DAY_IN_MILLIS, 0, 0,

to

mController.sendEventRelatedEventWithExtraWithTitleWithCalendarId(this, EventType.CREATE_EVENT, -1, mDateInMillis, mDateInMillis + -1, 0, 0,

mueller-ma commented 6 years ago

With this change it's still possible to create a full-day event. I create events that start and end on the same day much more often than events ending on the next day. And I think this is true for most users.