Etar-Group / Etar-Calendar

Android open source calendar
https://f-droid.org/packages/ws.xsoh.etar/
GNU General Public License v3.0
2.01k stars 391 forks source link

Foreground service notification #520

Open ByteHamster opened 5 years ago

ByteHamster commented 5 years ago

The app recently got a foreground notification for the AlarmService. This is quite distracting because I now receive 2 heads up cards per event. One that actually is about the event and one that just tells me that the service is running. I suggest to change the behavior so that only one notification is displayed. For this purpose, I have 2 possible solutions.

jspricke commented 5 years ago

Thanks for the analysis, can you come up with a pull request? Given the age of the code, I can imagine that your second option is correct (didn't look into the details), but trying your first option first would be fine with me as well.

ByteHamster commented 5 years ago

can you come up with a pull request?

Hmm I am quite busy currently. Let's see when this is bugging me enough to clone the repo :P

Gitsaibot commented 5 years ago

Convert the AlarmService to a JobIntentService

That's the way we should go. Besides this would solve #521 which is caused by using the same channelID, I think.

Cwpute commented 1 year ago

I am still having this problem. Has the issue been fixed for you since then @ByteHamster ?