Etar-Group / Etar-Calendar

Android open source calendar
https://f-droid.org/packages/ws.xsoh.etar/
GNU General Public License v3.0
2.04k stars 393 forks source link

UI overhaul to 'slim' down the ui #731

Open newhinton opened 4 years ago

newhinton commented 4 years ago

I have experimented with etar for some time, and i think it's ui could be improved in subtle ways.

There are many places where text is in bold. This can quickly overwhelm the ui. Generally we can change elements to be less intrusive without loosing its meaning.

Eg:

Monthview:

Screenshot

![summary_month](https://user-images.githubusercontent.com/25279821/86774465-db77bf80-c056-11ea-800f-b663e9451093.png) (left: current; right: proposal)

Here the day-indicator could be "moved to the back", which highlights the content (the events) even more.

Agenda:

Screenshot

Im sorry about the huge images ![slim_agenda](https://user-images.githubusercontent.com/25279821/86774938-45906480-c057-11ea-8b4b-f76710bfc874.png)

The Agenda also doesnt need bold text to indicate that it is in the future. If an event is not now or in the future, it can have a grey color, which conveys this meaning better since it is directly clear that those items are not important, and therefore "not visible". Bold could be used for an event that is current.

Those two were examples, this is applicable in nearly every view, to some extend.

Also i think rounded color chips &bars would look nice, although im still figuring out what looks best

jspricke commented 4 years ago

Sounds interesting, can you open pull requests so we can try it out?

newhinton commented 4 years ago

Currently i have quite a lot in my working copy, should i seperate them and make mulpile requests? (rounded chips, remove bold, etc)

jspricke commented 4 years ago

depends on how big they are, you can create one PR with everything and we can help you separating them later.

newhinton commented 4 years ago

Agendaday:

732

I think the colorchip can be improved, but i am not sure how right now.

newhinton commented 4 years ago

Monthview:

733

The chips are good, but i need to fix alldayevent rectangles, the text overlaps and looks ugly when they are rounded. Maybe they can stay rectangular.

Gitsaibot commented 4 years ago

It is nice to see that there are people who are willing to improve the ui interface. There are some things you should know when working on the ui:

  1. Some colours are not themed and "used" directly in all 3 themes(black, grey, white). So be careful changing colours.
  2. Your changes should work on tablets.
  3. Do not forget that we support API 19. So we have users with small screens and poor resolution. Recently I created a patch that brings the font size in week view to the same size as in month view. And after that there were people who complained that the font is now too small. Therefore I think if we have the space, we should use it ;)
newhinton commented 4 years ago

I have experimented with card layouts, i think this seperates the elements way better than the simple spacers used in the past. Also the 'Add reminder'-button is way more identifiable

Screenshot_1594200706

736

edit:

I have experimented quite a lot, the latest version does not have the topbar anymore, and uses a floating action button as save. The cancel button is gone completely. That increases the usable space for the event, even on api19

newhinton commented 4 years ago

Screenshot_1594207254

I dont know why the card is not the full width on api19, on the latest it has full size

newhinton commented 4 years ago

Screenshot_20200708-095743_Trebuchet

I also experimented with a new icon, this is the old one converted to svg with inkscape, on a background that is similar to etars "calendar".

newhinton commented 4 years ago

737

I'd like to move 'about' and 'Settings' to the bottom, but that is not that easy

image

newhinton commented 4 years ago

@Gitsaibot Could you help me with a feature i would like to implement?

I want to be able to select multiple days in monthview, which then get opened together in a weekview. So far i can calculate the start&end, but i have the problem that scrolling the monthview up&down breaks this by triggering 'MotionEvent.ACTION_CANCEL'

How is scrolling handled in the monthview, so that i can set a flag that allows the MonthByWeekAdapter to handle vertical movement?

Also i want to know if what i am doing is in your mind, or if i need to make changes/need to dump stuff.

newhinton commented 4 years ago

740 day/weekview

Gitsaibot commented 4 years ago

I want to be able to select multiple days in monthview, which then get opened together in a weekview

What is the benefit of this ?

How is scrolling handled in the monthview, so that i can set a flag that allows the MonthByWeekAdapter to handle vertical movement?

I'm afraid I don't know that. The code is complicated ;). Personally I think it would be better if the scrolling in the month view was the same as in the week view.

Also i want to know if what i am doing is in your mind, or if i need to make changes/need to dump stuff.

Do you mean this particular change or your others?

newhinton commented 4 years ago

What is the benefit of this ?

It allows to open a detailed view of a given range of days. Sometimes it can be useful to be able to see eg. a weekend or a specific range that is not determined by the weekview. I found it quite useful in the calendarapp that i used before, and tried to replicate it in etar.

I'm afraid I don't know that. The code is complicated ;). Personally I think it would be better if the scrolling in the month view was the same as in the week view.

Oh, i did not want to change how it works :D it just needs to be supressed shortly while a selection is beeing made, because currently if the user moves its finger not perfectly, the selection is canceled. Otherwise i dont want to change it.

Do you mean this particular change or your others?

All changes. I changed quite a lot visually, and some functionality, but i dont now if this is where etar wants to go and if i should continue or make changes. It would be sad to do all the work and not getting anywhere :D

Gitsaibot commented 4 years ago

Basically I agree with all your changes if they do not contain external dependencies. Is your new Etar icon adaptive? It would be interesting if we could use the background for an adaptive icon version.

newhinton commented 4 years ago

Basically I agree with all your changes if they do not contain external dependencies. Is your new Etar icon adaptive? It would be interesting if we could use the background for an adaptive icon version.

That's great! I think it is, do you mean that the homescreen icon uses the same color as set with the theme? i am not sure if that is possible.

Generally i have to cleanup everything, but there are still a few behavioural changes i want to make. Those are:

and maybe

I will upload an apk with all the merges when im done with 1-4 .

newhinton commented 4 years ago

Some screenshots of the current state:

Screenshot

![s-Screenshot_1597868556](https://user-images.githubusercontent.com/25279821/90686315-732e1780-e26b-11ea-91fe-402052a89c06.png) ![s-Screenshot_1597868560](https://user-images.githubusercontent.com/25279821/90686318-74f7db00-e26b-11ea-847a-8b18aa26bb27.png) ![s-Screenshot_1597868563](https://user-images.githubusercontent.com/25279821/90686324-76c19e80-e26b-11ea-8735-1b43a0144fba.png) ![s-Screenshot_1597868566](https://user-images.githubusercontent.com/25279821/90686328-788b6200-e26b-11ea-81d7-3d512afe25ba.png) ![s-Screenshot_1597868634](https://user-images.githubusercontent.com/25279821/90686336-79bc8f00-e26b-11ea-8186-8e836e08d7a4.png)

This is a debug build with the current changes Etar-Calendar-debug.zip

ByteHamster commented 4 years ago

Basically I agree with all your changes if they do not contain external dependencies. Is your new Etar icon adaptive? It would be interesting if we could use the background for an adaptive icon version.

That's great! I think it is, do you mean that the homescreen icon uses the same color as set with the theme?

Adaptive icons are icons with foreground and background that can be cut to fit any shape (some vendors use round icons, some square).

In case of your icon, it might look good to have the green bar only on the background layer and the borders of the calendar in foreground. This way, launchers can animate some interesting effects :)

I really like your icon proposal. It can be made adaptive and still really similar to the old icon, so it is still recognizable.

newhinton commented 3 years ago

I have a pretty well working example of the multiselect for monthview: #797 There is still a bit to do, but it generally works

newhinton commented 3 years ago

@jspricke @Gitsaibot Any news on what you think of my general changes? I created a branch with all the changes i made. Not everything is finished, and some things need to be rebased&changed according to the current master, but you get a feel for what i am trying to achieve. I can also provide an apk if required.

BlueDrink9 commented 3 years ago

I just want to chime in as another user and say your screenshots look great! I'm excited and hopeful that these changes can make it into Etar

newhinton commented 2 years ago

@BlueDrink9 Currently there does not seem to be a lot of progress in overhauling the ui, but if you like i can push my branch where i have merged most of my changes so that you can use them

BlueDrink9 commented 2 years ago

I'd love to try them if you can provide an apk (I don't have the build tools set up at the moment)

newhinton commented 2 years ago

@BlueDrink9 I have created a version that contains all the changes i have done. Albeit the new navigation drawer is missing and some stuff still needs to be done. I'd like to hear your feedback! newhinton-Etar-Calendar-debug.zip

BlueDrink9 commented 2 years ago

First thing I noticed is that the "pure black night mode" option isn't applying to the main calendar view in your version

BlueDrink9 commented 2 years ago

Also, the enter event name at the top when creating a new event is pure white, so the text is hidden

BlueDrink9 commented 2 years ago

Is there no way to cancel an event? Pressing back saves the new event same as pressing the save button. I quite like the new save button UI otherwise

BlueDrink9 commented 2 years ago

The new event sections look good, but without the bold event name, there is no way to distinguish in the text between the event and the location (in day/week view)

newhinton commented 2 years ago

Is there no way to cancel an event? Pressing back saves the new event same as pressing the save button. I quite like the new save button UI otherwise

yes, this is currently expected, it should dismiss the changes when going back. Noted!

The new event sections look good, but without the bold event name, there is no way to distinguish in the text between the event and the location (in day/week view)

True, i probably should make the location italic. Boldness should not be part of my design-changes, it is just to big for a good looking ui.

First thing I noticed is that the "pure black night mode" option isn't applying to the main calendar view in your version

It looks like the current master also does not support true darkmode in the calendarview, so this is expected at the moment

BlueDrink9 commented 2 years ago

That's odd… the fdroid version supports black. Are you sure?

newhinton commented 2 years ago

@Gitsaibot @jspricke Most of my changes are quite far progressed, and in regularly test them. Will they be merged eventually? It get's quite hard to keep them up to date, so i would like to consolidate all the chagnes so that i can work on different features for etar.

Also, etar will have to rethink it's ui at some point, because espeically with Android 12 there are some eements that will be forced to use corners which will divide the ui and look outdated. I think etar deserves a modern look that fits into the android look and feel

ltguillaume commented 2 years ago

I hope this will eventually be pulled, Etar is in dire need of some UI improvements imho.

@jspricke

SamuXzX commented 1 year ago

It's unfortunate Etar has such an old UI, given that it's the only FOSS calendar app I find usable. Any news?

TecCheck commented 1 year ago

Yeah, would be cool to have updates on this topic