search

EtchedPixels / FUZIX

FuzixOS: Because Small Is Beautiful
Other
2.13k stars 267 forks source link

Make USB uart separate from hardware UART #1060

Closed veremenko-y closed 3 months ago

veremenko-y commented 3 months ago

Also make hardware UART fully blocking for kput/kprintf

EtchedPixels commented 3 months ago

-extern uint8_t progbase[USERMEM]; +extern char progbase[USERMEM];

This seems to be unrelated and strange ?

Rest looks ok but please try and use (void) not () for no arg functions. The PI compiler doesn't care but no some targets there is a difference between "no arguments" and "K&R style who knows arguments"

veremenko-y commented 3 months ago

Rest looks ok but please try and use (void) not () for no arg functions. The PI compiler doesn't care but no some targets there is a difference between "no arguments" and "K&R style who knows arguments"

Ack. I'll go though the patch to ensure it doesn't happen again. Do you want me to add this to the CodingStyle.md? (which I realized I haven't read, but it does missing the foo(void)).

This seems to be unrelated and strange ?

This was part of fighting the compiler and conflicting types. I'll check this first and remove if unnecessary.

veremenko-y commented 3 months ago

Both issues should be addressed now.

EtchedPixels commented 3 months ago

Thanks - merged