dk-tm4c129x: fixes in the ethernet driver

EtchedPixels / FUZIX

FuzixOS: Because Small Is Beautiful

Other

2.18k stars 272 forks source link

dk-tm4c129x: fixes in the ethernet driver #909

Closed pawosm-arm closed 2 years ago

pawosm-arm commented 2 years ago

Three things were wrong:

'if' that was always true and was never needed blocked all of the recv traffic
recv buffers were never freed
/dev/eth was a block device while it should have been a character device

ICMP pings are now coming back from the device!

EtchedPixels commented 2 years ago

Yay

pawosm-arm commented 2 years ago

Hi @EtchedPixels,

~Thanks for merging it so quickly. I've noticed that my commit message was slightly confusing and pushed slight correction, but you were faster and the commit with old message got merged :) Anyway, this is not a big deal.~

False alarm! Seems I've managed to force-push the commit with the new commit message nanosecond before your merger, hence the right thing landed in the repo.