1.7 community 4.3

[zetti68]

Hello developers of Traincraft, I spent a little time to change four topics in Traincraft-6:

1. build.gradle, .gitignore I use Eclipse and changed something to get a working project with Eclipse and EGradle

2. Locomotive.java: compilation bug, Loader was not in imports

3. RecipeHander.java:

   • I added "sheetPlastic" and "platePlastic" (OreDictionary) to plastics to support GregTech6
   • If any kind of plastic without "dustPlastic" is available, "dustPlastic" is not necessary in recipes in my mind. If none of them is available, use "dustPlastic" in recipes.

4. NEIAssemblyTableRecipePlugin, NEITraincraftWorkbenchRecipePlugin: I hope, I found a working solution that handles recipes in NEI correctly. My fixes in detail:

   • show correct tier of results in assembly workbench
   • show recipes with correct cycling of materials found in ore dictionary
   • show correct count of recipes in usage mode

Please note, I only changed 1.7-community-4.3. I'm a little bit confused to find three different 1.7-branches. I hope, community branch was the right one to change.

Best regards Zetti68

[EternalBlueFlame]

This push will need some significant modifications before we can merge it.

This removes license files, both from file and through the gitIgnore, which is against the terms of service for multiple apis.

It adds a large number of unauthorized apis to the build Gradle, which scale from potentially questionable on usage rights, to invalid and could potentially cause issues in some workspaces.

It removes the necessary grade tech repositories from the build Gradle. The run directory is changed to eclipse which will cause a problem with eclipse runtime environments.

Likely the reason that you couldn't set it up correctly in eclipse was because you weren't using the Gradle import plugin. The previous setup worked just fine for eclipse.

The check for dust plastic should be an addition to the current check for plastic, rather than a replacement for if it's null, since there could be scenarios where both are true.

The changes to the crafting system define some significant structure changes to how the arrays and loops work, and I'll need to test those to be sure they work as intended.

Despite the issues, I am genuinely thrilled to see people working on this.

[zetti68]

I changed something once more:

NEITraincraft...Plugin and NEIAssembly...Plugin: optimized: do not change item in ingredients, set ingredients to next recipe instead and show it methods loadCraftingRecipes: given outputID do not match, special code was not necessary, deleted

I found not working recipes in Assembly table:

• a combination of OreDictionary.WILDCARD_VALUE and a count of item > 1 do not work. If the damage is set to WILDCARD, the count of item will be only 1.
• multi value items (e.g. GT's plankWood) show only one kind of item in NEI Solution:
• set ItemDamage to 0, if itemStack.getItemDamage() == OreDictionary.WILDCARD_VALUE
• use itemStack.getItemDamage(), if damage != wildcard.

I added item damage to coal and water bucket additionaly to prevent nonsense recipes like usage of "empty ingot"

[EternalBlueFlame]

looks good now, thanks for taking the extra effort.

[zetti68]

My best thanks. A wish you all the best.