search

EternalBlueFlame / Traincraft-5

Traincraft repository for version 1.7.x port.
Other
58 stars 53 forks source link

Fix weird rotating and derails on slopes #677

Closed tpeterka1 closed 8 months ago

tpeterka1 commented 8 months ago

This one line removal fixes derailments when going up slopes (these https://streamable.com/t3gy8h)

I tested it and it works fine now https://streamable.com/vvo6pf

EternalBlueFlame commented 8 months ago

omitting the super call breaks the bogie's interaction with some railcraft functionality.

tpeterka1 commented 8 months ago

I guess there must be an error in that then? Because it doesn't flip without the call.

EternalBlueFlame commented 8 months ago

Possibly but unlikely. If anything it's probably something like gravity logic or some garbage like that.

The thing is that railcraft functionality is injected into the host class (entity minecart) from railcraft, So if we don't call the super method then we can't use the features.

TheDoctor looked into this more, and from his testing moving the update call to after we've checked whether it's an extension of a vanilla/railcraft rail or not, seems to fix the problem in addition to keeping railcraft functionality.

So that will likely be how it gets done for the next release.

tpeterka1 commented 8 months ago

Alright then, thanks for clearing these things up for me