EternalWraith / PalEdit

A simple tool for Editing and Generating Pals within PalWorld Saves
MIT License
478 stars 68 forks source link

Fix max hp being calculated too early, added boss hp scaling for frostallion, and reflect iv changes on in-game stats immediately #126

Closed KrisCris closed 6 months ago

KrisCris commented 7 months ago

Issue:

Fix:

Feat:

KrisCris commented 7 months ago

Apologize if any confusion was caused by my old handleMaxHealthUpdates(self, pal, changes) method - the changes arg is the key for ensuring the correctness of the HP calculation even if in the wrong order, for the old methods introduced in PR: https://github.com/magicbear/PalEdit/pull/1. At the time, I was trying to calculate the possible hp scaling before updating the stats, such that an alert can pop up if the difference is too big between scaling in our data and the calculated one, since some boss scalings might be missing.

after testing against all the bosses I could get in the game, I think Frostallion is the only one missing : )

and I think these can be closed:

KrisCris commented 6 months ago

Since you've done the exact same fix by yourself, and have no plan merging this PR, I am going to close it.