EternalWraith / PalEdit

A simple tool for Editing and Generating Pals within PalWorld Saves
MIT License
480 stars 68 forks source link

Sold tower boss stay in game files #85

Closed Swoup closed 8 months ago

Swoup commented 8 months ago

Used the tools to make the five tower bosses. Then changed my mind and sold them for 0 at the Black Marketeer. They still appear when I load my file in the tool but don't appear in my palbox.

jim972329667 commented 8 months ago

Can you send me the archive? I‘m trying to fix it.

Swoup commented 8 months ago

Sure if you can tell me where to find such archive.

On Mon, Feb 5, 2024, 18:23 jim972329667 @.***> wrote:

Can you send me the archive? I‘m trying to fix it.

— Reply to this email directly, view it on GitHub https://github.com/EternalWraith/PalEdit/issues/85#issuecomment-1927522390, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF4X7UZQM76F3J7DBVDHPLYSEIRHAVCNFSM6AAAAABCZGROPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGUZDEMZZGA . You are receiving this because you authored the thread.Message ID: @.***>

Swoup commented 8 months ago

Welp I just read again 2min later and you asked for the save file didnt you ?

jim972329667 commented 8 months ago

Yeah, json files and sav files are fine

Swoup commented 8 months ago

https://www.dropbox.com/scl/fi/cmwt1qpzof9vexqn7myqa/Level.zip?rlkey=03soeg0wzegz1uduyyx5n9s25&dl=0

level.sav file

jim972329667 commented 8 months ago

Did you add the pallu yourself using Json?

jim972329667 commented 8 months ago

I found that you have two pal stored in the same grid. This may be cause by pal only added to CharacterSaveParameterMap.

jim972329667 commented 8 months ago

I have fixed in my branch. https://github.com/jim972329667/PalEdit/tree/Jim97_main

Swoup commented 8 months ago

I never used the Json file, only the tool UI

On Tue, Feb 6, 2024, 14:20 jim972329667 @.***> wrote:

Did you add the pallu yourself using Json?

— Reply to this email directly, view it on GitHub https://github.com/EternalWraith/PalEdit/issues/85#issuecomment-1929570214, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF4X7RRAYCRZSSKSGBNHZ3YSIUZDAVCNFSM6AAAAABCZGROPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGU3TAMRRGQ . You are receiving this because you authored the thread.Message ID: @.***>

Swoup commented 8 months ago

Did you mean this in relation with the phantom tower boss pals in the files

I found the Ice Reptyro is bugged in the UI (whenever I click it, it shows whatever pal I clicked last before). It could be related to this "two pal stored in the same grid" situation?

On Tue, Feb 6, 2024, 14:22 jim972329667 @.***> wrote:

I found that you have two pal stored in the same grid. This may be cause by pal only added to CharacterSaveParameterMap.

— Reply to this email directly, view it on GitHub https://github.com/EternalWraith/PalEdit/issues/85#issuecomment-1929582804, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF4X7XHIA2CRXT26QTA4PTYSIVDDAVCNFSM6AAAAABCZGROPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGU4DEOBQGQ . You are receiving this because you authored the thread.Message ID: @.***>

Swoup commented 8 months ago

I will test that branch in 3-5 hours. Thanks

On Tue, Feb 6, 2024, 15:13 jim972329667 @.***> wrote:

I have fixed in my branch. https://github.com/jim972329667/PalEdit/tree/Jim97_main

— Reply to this email directly, view it on GitHub https://github.com/EternalWraith/PalEdit/issues/85#issuecomment-1929767090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF4X7UNS56G4MRP7F2V7VLYSI3BNAVCNFSM6AAAAABCZGROPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZG43DOMBZGA . You are receiving this because you authored the thread.Message ID: @.***>

jim972329667 commented 8 months ago

image

Add this code to remove the storage conflict pals

Swoup commented 8 months ago

Can confirm sold tower bosses are gone.

Previously bugged Ice Reptyro now shows as unknown pal silhouette (Isnt it Reptyro Cryst rather than Ice Reptyro ? Is there a name matching somehwere ?) with everything else now proper.

Branch mentions faster serialization. I confirm it does feel faster (no hard data though)

Thanks. Good job. Closing the issue.

NoctLion commented 8 months ago

Add this code to remove the storage conflict pals

Adding the code provided also deleted some caught human (merchant) pals that weren't sold/condensed/deleted as they also appear as errors/unknown during the creation of entity when loading the save file with PalEdit.

Error occured: 'PalDealer_Desert' Error occured: 'SalesPerson_Desert2' Error occured: 'SalesPerson_Volcano2' Error occured: 'PalDealer_Volcano' Error occured: 'SalesPerson_Volcano'

The other merchants are fine such as the Black Marketeer and the most basic Wandering Merchant that sells blue Pal Sphere and Schematics and Pal Merchant that mostly sells early game pals like Chikipi/Lamball/Cattiva.

Edit: Adding the entries for these unknowns in the resources\data\pals.json fixes the issue, but I'm not sure if there are more of these that I haven't caught that are not in the list too.

jim972329667 commented 8 months ago

Add this code to remove the storage conflict pals

Adding the code provided also deleted some caught human (merchant) pals that weren't sold/condensed/deleted as they also appear as errors/unknown during the creation of entity when loading the save file with PalEdit.

Error occured: 'PalDealer_Desert' Error occured: 'SalesPerson_Desert2' Error occured: 'SalesPerson_Volcano2' Error occured: 'PalDealer_Volcano' Error occured: 'SalesPerson_Volcano'

The other merchants are fine such as the Black Marketeer and the most basic Wandering Merchant that sells blue Pal Sphere and Schematics and Pal Merchant that mostly sells early game pals like Chikipi/Lamball/Cattiva.

Edit: Adding the entries for these unknowns in the resources\data\pals.json fixes the issue, but I'm not sure if there are more of these that I haven't caught that are not in the list too.

I had fix that unknow pal in my version.