search

EternallLight / cordova-plugin-openwith-ios

A modified version of the Cordova iOS Share extension (cordova-plugin-openwith) by Jean-Christophe Hoelt for iOS. Supports receiving shared URLs, text and images as well as sharing several images at once.
https://web-mystery.com/
MIT License
28 stars 84 forks source link

LoggedIn to WHAT? #20

Closed bendspoons closed 4 years ago

bendspoons commented 4 years ago

Just a simple question: logged to WHAT? I have absolutely NO Idea, what this means.

EternallLight commented 4 years ago

This is intended for usage in apps that require signing in before sharing. Unless you are sign in, you cannot share the data to your contacts in the app, for instance. It is disabled by default, so if you don't need it, you don't have to worry about it.

bendspoons commented 4 years ago

thanks for the reply, but it says always I'm not logged in. Always, i does not matter what i do.

Normally, when adding

` // Set logged in status

cordova.openwith.setLoggedIn(true);`

the login shouldn't be asked. But it does. Always. Wouldn't it be nice, if such a special feature would ONLY be available if i explicitly enable it?

I just removed the whole part of the code for this part.

bendspoons commented 4 years ago

Hey, im sorry for being that explicit in my comment. Had a rough day where nothing worked. Made a fork and make my needed changes there. Thanks for the work!

EternallLight commented 4 years ago

@bendspoons thank you for the report. I removed the isLoggedIn functionality completely from the version 2 of the plugin as it seems to be a very specific case. Feel free to use this branch https://github.com/EternallLight/cordova-plugin-openwith-ios/tree/release/v2.0.0 before it is merged into master.