search

EternallLight / cordova-plugin-openwith-ios

A modified version of the Cordova iOS Share extension (cordova-plugin-openwith) by Jean-Christophe Hoelt for iOS. Supports receiving shared URLs, text and images as well as sharing several images at once.
https://web-mystery.com/
MIT License
28 stars 84 forks source link

[Feature] Support CI builds #23

Open HarelM opened 4 years ago

HarelM commented 4 years ago

I have read the documentation and can't understand if there's a way to use this plugin without manual work. My current project uses the original plug-in for android, but it doesn't use it for iOS since there's manual work that needs to be done which I can't do when building a version on a CI machine. See here: https://github.com/j3k0/cordova-plugin-openwith/issues/82 I don't mind using this plugin only for iOS as it seems to be intended this way, but I need a way to make it run on my build machine without opening xcode and changing stuff manually.

Is it possible? My project is open source in case you would like to understand more: https://github.com/IsraelHikingMap/Site/

HarelM commented 4 years ago

@EtienneLem I saw that you created a fork of this repository and removed the manual instructions related to xcode and change the cordova add code. Where you able to fully automate this process? Also does you plugin supports Android as well? Sorry for asking here, but it's not possible to open an issue on your fork...

EtienneLem commented 4 years ago

I saw that you created a fork of this repository and removed the manual instructions related to xcode and change the cordova add code. Where you able to fully automate this process?

Yeup! 😎Secret lies in these 2 commits: https://github.com/missive/cordova-plugin-openwith/commit/6c55d1abedcad37a02ed1a60cdb7ff2c7b6c88fe & https://github.com/missive/cordova-plugin-openwith/commit/190417161f0f5649e631079261eb9240128182d7. The manual steps of setting the app capabilities can be done via a plugin <config-file> options and we also inject a new entitlement file into the share extension target. Some more refactoring has been done since these original commits, final version on master.

Your mileage may vary, we have a pretty complex toolset on top of Cordova to allow us to set different plugins on different platforms, have dynamic config (multiple bundle IDs support, etc).

Also does you plugin supports Android as well?

It does 🤖

Sorry for asking here, but it's not possible to open an issue on your fork...

No worries 👍