EternoSeeker / gameoflife

Conway's Game of Life
https://eternalgameoflife.netlify.app/
GNU General Public License v3.0
47 stars 103 forks source link

GridSize changes when applying a preset #305

Closed partha120804 closed 1 week ago

partha120804 commented 2 weeks ago

Description

When grid sizes are set below 30 the Preset applying was not as expected. Fixed the bug now applying a preset resets the grid size to 30.

Related Issue

Closes #302

Checklist

netlify[bot] commented 2 weeks ago

Deploy Preview for eternalgameoflife ready!

Name Link
Latest commit ea2e23ad60b6214dd00288fc5bf41579a035d23c
Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/6677b9257c907f0008e783c1
Deploy Preview https://deploy-preview-305--eternalgameoflife.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

partha120804 commented 2 weeks ago

@EternoSeeker please review this PR

EternoSeeker commented 2 weeks ago

I think we can allow setting presets for sizes more than 30, it's just the smaller sizes that'll cause problems. since some presets would look nice in larger grids so we should allow for >= 30 but reset for sizes less than 30

partha120804 commented 2 weeks ago

@EternoSeeker done, please check it